OPRUN-4056: [OTE] Migrate preflight checks from openshift/origin by camilamacedo86 · Pull Request #423 · openshift/operator-framework-operator-controller

camilamacedo86 · 2025-08-07T17:56:06Z

Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies.

The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs.

You can check the PR to delete the migrated tests here : openshift/origin#30074 ( it might help you validate )

Tests:

https://pr-payload-tests.ci.openshift.org/runs/ci/cab853e0-7a77-11f0-80dc-0a55ab730901-0

openshift-ci-robot · 2025-08-07T17:59:03Z

@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies.

The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs.

Assisted-by: Gemini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-08-07T17:59:40Z

@@ -1,4 +1,64 @@
 [
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {services} are not specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1992

camilamacedo86 · 2025-08-07T17:59:58Z

+    "environmentSelector": {}
+  },
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {create} verb is not specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1988

camilamacedo86 · 2025-08-07T18:00:18Z

+    "environmentSelector": {}
+  },
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {ClusterRoleBindings} are not specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1982

camilamacedo86 · 2025-08-07T18:00:40Z

+    "environmentSelector": {}
+  },
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {ConfigMap:resourceNames} are not all specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1984

camilamacedo86 · 2025-08-07T18:00:58Z

+    "environmentSelector": {}
+  },
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {clusterextension/finalizer} is not specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1986

camilamacedo86 · 2025-08-07T18:01:18Z

+    "environmentSelector": {}
+  },
+  {
+    "name": "[sig-olmv1][OCPFeatureGate:NewOLMPreflightPermissionChecks][Skipped:Disconnected] OLMv1 operator preflight checks should report error when {escalate, bind} is not specified",


Same name: https://github.com/openshift/origin/blob/7ccc307375be090b9a6fb44b713dcbfe318430be/test/extended/util/annotate/generated/zz_generated.annotations.go#L1990

openshift-ci-robot · 2025-08-07T18:06:29Z

@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies.

The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs.

You can check the PR to delete the migrated tests here : openshift/origin#30074 ( it might help you validate )

Assisted-by: Gemini

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

camilamacedo86 · 2025-08-07T20:34:25Z

/retest-required

camilamacedo86 · 2025-08-08T00:13:30Z

/test openshift-e2e-aws

tmshort · 2025-08-08T15:16:00Z

/test openshift-e2e-aws-techpreview
Why are the tech preview tests failing?

camilamacedo86 · 2025-08-08T19:00:32Z

/hold

We should wait for the new branch cut before proceeding.
But it can be reviewed, please !!!

kuiwang02 · 2025-08-12T00:44:03Z

/lgtm

please note: the merge is held because of cutting branch. so, better to wait for that.

camilamacedo86 · 2025-08-17T21:34:57Z

/test openshift-e2e-aws

openshift-ci-robot · 2025-08-18T05:53:54Z

@camilamacedo86: This pull request references OPRUN-4056 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies.

The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs.

You can check the PR to delete the migrated tests here : openshift/origin#30074 ( it might help you validate )

Tests:

https://pr-payload-tests.ci.openshift.org/runs/ci/cab853e0-7a77-11f0-80dc-0a55ab730901-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kuiwang02 · 2025-08-18T06:20:31Z

/lgtm

please note: the merge is held because of cutting branch. so, better to wait for that.

perdasilva · 2025-08-20T08:32:36Z


 METADATA := $(shell pwd)/.openshift-tests-extension/openshift_payload_olmv1.json

+


Do we need the changes in this file?

No we do not need :-(
We need rebase with main
But we will miss the tests

Fixed !!! 👍

Migrated OLMv1 operator preflight checks from using external YAML files to defining ClusterRole permissions directly in Go structs. This improves test reliability and simplifies test setup by removing file dependencies. The changes ensure precise replication of original test scenarios, including specific permission omissions for services, create verbs, ClusterRoleBindings, ConfigMap resourceNames, and escalate/bind verbs. Assisted-by: Gemini

camilamacedo86 · 2025-08-20T09:14:06Z

Hi @perdasilva

I rebased with main and addressed your comment ( remove unnecessary space in the file which end up due rebases)
But we lose the lgtm.
Could you re-add both for we get it merged?

perdasilva · 2025-08-20T09:37:33Z

/approve

perdasilva · 2025-08-20T09:38:11Z

/lgtm

openshift-ci · 2025-08-20T09:38:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

camilamacedo86 · 2025-08-20T10:54:58Z

/payload-aggregate /payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 5

openshift-ci · 2025-08-20T10:55:01Z

@camilamacedo86: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

camilamacedo86 · 2025-08-20T10:55:20Z

/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview 5

openshift-ci · 2025-08-20T10:55:25Z

@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2adbf990-7db4-11f0-8f39-b7de71564e96-0

camilamacedo86 · 2025-08-20T10:57:15Z

/hold

Until we get the result of the latest

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2adbf990-7db4-11f0-8f39-b7de71564e96-0

Just to be very extra safe

camilamacedo86 · 2025-08-20T15:23:58Z

/hold cancel

All finished with success as well , see: https://github.com/openshift/operator-framework-operator-controller/pulls#issuecomment-3205609482

openshift-ci-robot · 2025-08-20T16:03:12Z

/retest-required

Remaining retests: 0 against base HEAD 79325a1 and 2 for PR HEAD 863cfdf in total

camilamacedo86 · 2025-08-20T18:53:36Z

/test openshift-e2e-aws

openshift-ci · 2025-08-20T22:29:50Z

@camilamacedo86: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/openshift-e2e-aws-techpreview	`863cfdf`	link	false	`/test openshift-e2e-aws-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci Bot requested review from anik120 and oceanc80 August 7, 2025 17:56

camilamacedo86 changed the title ~~[OTE] Migrate preflight checks from openshift/origin~~ OPRUN-4056: [OTE] Migrate preflight checks from openshift/origin Aug 7, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2025

camilamacedo86 commented Aug 7, 2025

View reviewed changes

This was referenced Aug 8, 2025

OPRUN-4056: [OLMv1] Remove Preflight checks since those were migrated to OTE openshift/origin#30074

Merged

OPRUN-4055: [OLMv1] Remove olmv1.go tests since those has been executed by OTE openshift/origin#30072

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025

camilamacedo86 force-pushed the migrate-preflight branch from ba99815 to daa1fc3 Compare August 8, 2025 18:55

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025

openshift-ci Bot assigned kuiwang02 Aug 12, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025

camilamacedo86 force-pushed the migrate-preflight branch from daa1fc3 to 19d9da6 Compare August 12, 2025 10:12

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2025

camilamacedo86 force-pushed the migrate-preflight branch from 19d9da6 to 205878b Compare August 12, 2025 10:19

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025

perdasilva reviewed Aug 20, 2025

View reviewed changes

camilamacedo86 force-pushed the migrate-preflight branch from 2e69a2c to 5c4e09d Compare August 20, 2025 09:10

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025

camilamacedo86 force-pushed the migrate-preflight branch from 5c4e09d to 863cfdf Compare August 20, 2025 09:12

camilamacedo86 requested a review from perdasilva August 20, 2025 09:13

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025

openshift-ci Bot assigned perdasilva Aug 20, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025

openshift-merge-bot Bot merged commit f9bf348 into openshift:main Aug 20, 2025
12 of 13 checks passed

camilamacedo86 deleted the migrate-preflight branch August 20, 2025 22:53


		METADATA := $(shell pwd)/.openshift-tests-extension/openshift_payload_olmv1.json

Conversation

camilamacedo86 commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 7, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 7, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camilamacedo86 commented Aug 7, 2025

Uh oh!

camilamacedo86 commented Aug 8, 2025

Uh oh!

tmshort commented Aug 8, 2025

Uh oh!

camilamacedo86 commented Aug 8, 2025

Uh oh!

kuiwang02 commented Aug 12, 2025

Uh oh!

camilamacedo86 commented Aug 17, 2025

Uh oh!

openshift-ci-robot commented Aug 18, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kuiwang02 commented Aug 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

perdasilva commented Aug 20, 2025

Uh oh!

perdasilva commented Aug 20, 2025

Uh oh!

openshift-ci Bot commented Aug 20, 2025

Uh oh!

camilamacedo86 commented Aug 20, 2025

Uh oh!

openshift-ci Bot commented Aug 20, 2025

Uh oh!

camilamacedo86 commented Aug 20, 2025

Uh oh!

openshift-ci Bot commented Aug 20, 2025

Uh oh!

camilamacedo86 commented Aug 20, 2025

Uh oh!

camilamacedo86 commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

camilamacedo86 commented Aug 20, 2025

Uh oh!

openshift-ci Bot commented Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

camilamacedo86 commented Aug 7, 2025 •

edited

Loading

openshift-ci-robot commented Aug 7, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Aug 7, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Aug 18, 2025 •

edited by openshift-ci Bot

Loading

camilamacedo86 Aug 20, 2025 •

edited

Loading

camilamacedo86 commented Aug 20, 2025 •

edited

Loading