Skip to content

NO-ISSUE: Remove bindata generation from build#438

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:fix-go-bindata
Aug 15, 2025
Merged

NO-ISSUE: Remove bindata generation from build#438
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
tmshort:fix-go-bindata

Conversation

@tmshort
Copy link
Copy Markdown
Contributor

@tmshort tmshort commented Aug 15, 2025

Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run the bindata target to refresh the bindata, or use the build-update target.

This is a quickfix to put out the fire.

@tmshort
UPSTREAM: <carry>: Remove bindata generation from build
1c3d036 
Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run
the `bindata` target to refresh the bindata, or use
the `build-update` target.

This is a quickfix to put out the fire.

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2025
camilamacedo86
camilamacedo86 approved these changes Aug 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tmshort tmshort changed the title UPSTREAM: <carry>: Remove bindata generation from build NO-ISSUE: Remove bindata generation from build Aug 15, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 15, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 15, 2025

@tmshort: This pull request explicitly references no jira issue.

Details

In response to this:

Using go-bindata is causing problems with ART builds.

This removes the use of go-bindata from the builds.

This will subsequently require that users MANUALLY run the bindata target to refresh the bindata, or use the build-update target.

This is a quickfix to put out the fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort tmshort mentioned this pull request Aug 15, 2025
Closed
@tmshort
Copy link
Copy Markdown
Contributor Author

tmshort commented Aug 15, 2025 •
edited
Loading

/override ci/prow/openshift-e2e-aws
/skip

 [sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s]

is a known flake outside this pr
#434 (comment)

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2025

@tmshort: Overrode contexts on behalf of tmshort: ci/prow/openshift-e2e-aws

Details

In response to this:

/override ci/prow/openshift-e2e-aws
/skip

[sig-instrumentation] Metrics should grab all metrics from kubelet /metrics/resource endpoint [Suite:openshift/conformance/parallel] [Suite:k8s] is a known flake outside this pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9a4865e into openshift:main Aug 15, 2025
13 checks passed
@tmshort tmshort deleted the fix-go-bindata branch August 15, 2025 17:57
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 15, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-operator-controller
This PR has been included in build ose-olm-operator-controller-container-v4.20.0-202508151949.p0.g9a4865e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Aug 15, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-olm-catalogd
This PR has been included in build ose-olm-catalogd-container-v4.20.0-202508151949.p0.g9a4865e.assembly.stream.el9.
All builds following this will include this PR.

@tmshort tmshort mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gallettilance gallettilance Awaiting requested review from gallettilance

@oceanc80 oceanc80 Awaiting requested review from oceanc80

1 more reviewer

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmshort @openshift-ci-robot @openshift-bot @camilamacedo86