NO-ISSUE: Add verify bindata#441
Conversation
|
@camilamacedo86: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
camilamacedo86
force-pushed
the
add-verify-bindata
branch
from
9e7f195 to
fbae924
Compare
|
This does not actually invoke the tests-extension verify from CI. |
|
Hi @tmshort
It failed when I did not added the build to update-metadata |
|
OK. |
| #SECTION Development | ||
| .PHONY: verify #HELP To verify the code | ||
| verify: tidy fmt vet lint | ||
| verify: tidy fmt vet lint verify-metadata |
There was a problem hiding this comment.
@joelanford commented on PR439, that this should have git diff --exit-code as part of this recipe.
There was a problem hiding this comment.
It has @if ! git diff --exit-code >&/dev/null;
There was a problem hiding this comment.
Yes, but that should not be buried in verify-manifests
| # Do not set globally. | ||
| .PHONY: build | ||
| build: bindata #HELP Build the extended tests binary | ||
| build: #HELP Build the extended tests binary |
There was a problem hiding this comment.
This might cause a conflict with #438, which we are prioritizing.
There was a problem hiding this comment.
It is fine we can wait that one get merged
|
Please rebase this PR onto the latest main and I will take a look |
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Why was this closed? My PR #439 was having problems with the verify CI, so I'm giving up on it. |
4 participants
No description provided.