NO-ISSUE: UPSTREAM: <carry>: Enhance clenup cluster catalog created for webhook…#459
NO-ISSUE: UPSTREAM: <carry>: Enhance clenup cluster catalog created for webhook…#459camilamacedo86 wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
camilamacedo86
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@camilamacedo86: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Add AfterAll hook to cleanup leftover ClusterCatalog resource using EnsureCleanupClusterCatalog helper function. Assisted-by: Cursor
camilamacedo86
force-pushed
the
enhance-cleanup-catalog
branch
from
337ed7c to
a478980
Compare
| }) | ||
|
|
||
| AfterAll(func(ctx SpecContext) { | ||
| helpers.EnsureCleanupClusterCatalog(ctx, webhookCatalogName) |
There was a problem hiding this comment.
I have one concern:
The only way to clean it is with AfterALL
However, can we really use AfterAll with OTE?
If I remember correctly, I read in a comment that it might not work well, which is why it was not added in the first place.
There was a problem hiding this comment.
What are you trying to clean up here? The catalogs are not all cleaned up?
There was a problem hiding this comment.
For the webhook tests, we create a Catalog.
This Catalog is shared across all tests. That is why we can only clean AfterAll
By design, it was not cleaned up before.
(I am not sure if we can use AfterAll, but if we can, that might be the only way.)
Please see EnsureCleanupClusterCatalog.
This helper makes sure the Catalog is cleaned up:
Why was this not added earlier?
There is some history here:
👉 openshift/origin#30059 (comment)
Because of that, I am not sure if it is completely safe to add now.
I think we need confirm.
So, for now, I would suggest:
- Put this PR on /hold
- It doesn’t seem safe to take the risk before TDB
- Our checks already confirm that everything is cleaned properly
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing this one |
3 participants
To validate the cleanup of the solution Cursor was used to generate a comprehensive script.
Before the changes
After we cleanup the webhook catalog
See attached the scripts used:
comprehensive_cleanup_validation.sh
output.result.txt