OPRUN-3863: Add olmv1 webhook support origin tests#30059
OPRUN-3863: Add olmv1 webhook support origin tests#30059anik120 wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
anik120
force-pushed
the
olmv1-webhook-support
branch
from
ba45fbc to
6a25d73
Compare
openshift-merge-robot
removed
the
needs-rebase
anik120
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@anik120: This pull request references OPRUN-3863 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Updates I made in this PR:
Each g.It() test now focuses purely on its validation logic without setup/teardown boilerplate |
|
/lgtm |
|
/retest-required |
|
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview |
|
@anik120: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5402540-72c5-11f0-93eb-36890be0318a-0 |
|
/test e2e-aws-ovn-serial-2of2 |
|
Job Failure Risk Analysis for sha: 6a25d73
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 6a25d73
New tests seen in this PR at sha: 6a25d73
|
|
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview |
|
@anik120: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2bb869c0-7396-11f0-930b-67f82cd1327a-0 |
|
/lgtm |
|
@sjenning @DennisPeriquet can I get approval for this PR please. |
|
/assign @DennisPeriquet |
Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini
Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini
openshift-ci
Bot
added
the
do-not-merge/hold
|
/hold cancel |
|
@anik120: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@anik120: This pull request references OPRUN-3863 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 5 |
|
/payload-aggregateperiodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 5 |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 5 |
|
@anik120: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/70b697e0-7a12-11f0-8696-f57cbfbf49ca-0 |
Skip "should be tolerant to openshift-service-ca certificate rotation". More info: https://issues.redhat.com/browse/OCPBUGS-60564 - Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
- Increase the timeout for "should be tolerant to openshift-service-ca certificate rotation" from 2 minutes to 5 minutes to reduce flakes. - Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini
|
Job Failure Risk Analysis for sha: 36e4247
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 36e4247
New tests seen in this PR at sha: 36e4247
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 36e4247
New tests seen in this PR at sha: 36e4247
|
|
Looks like the cert rotation test is problematic /close |
|
@anik120: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Skip "should be tolerant to openshift-service-ca certificate rotation". More info: https://issues.redhat.com/browse/OCPBUGS-60564 - Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
- Increase the timeout for "should be tolerant to openshift-service-ca certificate rotation" from 2 minutes to 5 minutes to reduce flakes. - Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
- Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
- Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini
Migrates OLMv1 webhook operator tests from using external YAML files to defining resources in Go structs. This change removes file dependencies, improving test reliability and simplifying test setup. The migration is a refactoring of code from openshift/origin#30059. The new code uses better naming conventions and adapts the tests to work with a controller-runtime client, enhancing test consistency and maintainability. The migration covers all core test scenarios: - Validating, mutating, and conversion webhooks. - Certificate and secret rotation tolerance. Assisted-by: Gemini
- Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
- Add dumping of container logs and `kubectl describe pods` output for better diagnostics. - Include targeted certificate details dump (`tls.crt` parse) when failures occur. - Add additional check to verify webhook responsiveness after certificate rotation. This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
… certificate rotation This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
… certificate rotation This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
… certificate rotation This change is a refactor of code from openshift/origin#30059. Assisted-by: Gemini
7 participants
Taking @perdasilva's #29825 to address blocking comment:
Original PR description:
Adds origin tests for the webhook support feature. Test need to be run serially to enable BeforeSuite functionality which installs the webhook operator for the tests:
check validating webhook
check mutating webhook
check conversion webhook
check service availability during cert secret deletion by continuously creating and deleting a resource after the deletion of the cert secret
check deployment availability during cert rotation, which is forced to happen when the openshift-service-ca signing key gets deleted.
Adds origin tests for the webhook support feature. Test need to be run serially to enable BeforeSuite functionality which installs the webhook operator for the tests:
check validating webhook
check mutating webhook
check conversion webhook
check service availability during cert secret deletion by continuously creating and deleting a resource after the deletion of the cert secret
check deployment availability during cert rotation, which is forced to happen when the openshift-service-ca signing key gets deleted.
(I'm not sure I'd add the last two if it weren't for the need to have 5 tests)