go vet pkg#1408
Merged
openshift-bot merged 1 commit intoopenshift:masterfrom Mar 23, 2015
0xmichalis:vet-pkg
Merged
Conversation
Contributor
There was a problem hiding this comment.
is it more idiomatic to explicitly name keys?
Contributor
Author
There was a problem hiding this comment.
go vet yells on unkeyed fields in struct literals so I guess it is.
There are still some more warnings though but I preffered not to touch them.
$ go vet pkg/
pkg/auth/oauth/handlers/authenticator_test.go:40: arg testCase.ExpectedAuthorized for printf verb %b of wrong type: bool
pkg/auth/oauth/registry/registry_test.go:286: github.com/GoogleCloudPlatform/kubernetes/pkg/util.Time composite literal uses unkeyed fields
pkg/auth/oauth/registry/registry_test.go:307: github.com/GoogleCloudPlatform/kubernetes/pkg/util.Time composite literal uses unkeyed fields
pkg/build/registry/etcd/etcd_test.go:21: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/build/registry/etcd/etcd_test.go:21: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/build/webhook/github/github_test.go:239: arg proceed for printf verb %s of wrong type: bool
pkg/build/webhook/github/github_test.go:255: arg proceed for printf verb %s of wrong type: bool
pkg/build/webhook/github/github_test.go:279: arg proceed for printf verb %s of wrong type: bool
pkg/cmd/experimental/registry/registry.go:160: github.com/GoogleCloudPlatform/kubernetes/pkg/client/clientcmd.ClientConfigLoadingRules composite literal uses unkeyed fields
pkg/cmd/infra/router/router.go:94: unreachable code
pkg/cmd/server/admin/overwrite_bootstrappolicy.go:93: kubectl.ShortcutExpander composite literal uses unkeyed fields
pkg/cmd/server/etcd/etcd.go:80: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/cmd/server/etcd/etcd.go:80: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/cmd/server/origin/master.go:543: unresolvable package for assetfs.AssetFS literal
pkg/cmd/server/origin/master.go:783: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/cmd/server/origin/master.go:783: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/cmd/server/start/start_allinone.go:222: unreachable code
pkg/cmd/server/start/start_master.go:153: unreachable code
pkg/cmd/server/start/start_node.go:123: unreachable code
pkg/cmd/util/clientcmd/factory.go:66: github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl.ShortcutExpander composite literal uses unkeyed fields
pkg/config/cmd/cmd.go:35: github.com/GoogleCloudPlatform/kubernetes/pkg/kubectl/resource.Mapper composite literal uses unkeyed fields
pkg/deploy/registry/etcd/etcd_test.go:56: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/deploy/registry/etcd/etcd_test.go:56: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/image/registry/image/etcd/etcd_test.go:61: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/image/registry/imagerepository/etcd/etcd_test.go:27: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/image/registry/imagerepositorymapping/rest_test.go:28: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/image/registry/imagerepositorytag/rest_test.go:26: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/image/registry/imagestreamimage/rest_test.go:22: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/oauth/registry/etcd/etcd_test.go:20: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/oauth/registry/etcd/etcd_test.go:20: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/oauth/server/osinserver/registrystorage/storage.go:159: github.com/GoogleCloudPlatform/kubernetes/pkg/util.Time composite literal uses unkeyed fields
pkg/oauth/server/osinserver/registrystorage/storage.go:199: github.com/GoogleCloudPlatform/kubernetes/pkg/util.Time composite literal uses unkeyed fields
pkg/route/registry/etcd/etcd_test.go:42: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/route/registry/etcd/etcd_test.go:42: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/template/registry/etcd/etcd_test.go:18: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
pkg/user/registry/etcd/etcd_test.go:19: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.EtcdHelper composite literal uses unkeyed fields
pkg/user/registry/etcd/etcd_test.go:19: github.com/GoogleCloudPlatform/kubernetes/pkg/tools.RuntimeVersionAdapter composite literal uses unkeyed fields
Contributor
|
awesome stuff @Kargakis ! LGTM |
Contributor
Author
|
[test] |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1418/) |
Contributor
There was a problem hiding this comment.
This should include the error message
Contributor
Author
|
@smarterclayton comments addressed |
Contributor
Author
|
re[test] |
Contributor
|
LGTM [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1264/) (Image: devenv-fedora_1110) |
Contributor
|
Evaluated for origin up to 897e4bb |
openshift-bot
pushed a commit
that referenced
this pull request
Mar 23, 2015
Merged by openshift-bot
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Oct 23, 2017
…service-catalog/' changes from aa27078754..dabde2eb85 dabde2eb85 origin build: add origin tooling b70c076 Reorder class and plan creation; test plan conflict handling (openshift#1459) 4bea012 Use versioned client APIs (openshift#1458) ff4af30 clean up logic for 410 gone deprovision poll (openshift#1452) 3fddf27 clean up logic and fix message for failed poll (openshift#1451) 40926cd Fix typo from openshift#1354 (openshift#1456) ff86ef2 Delete removed serviceplans when they have no instances left (openshift#1444) 8411a16 tweak binding setAndUpdateOrphanMitigation function (openshift#1448) ce28252 Combine apiserver and controller-manager into a single service-catalog image (openshift#1343) 7bbc8ee Check service class / plan before allowing provisioning or plan changes. (openshift#1439) baf28de Create listers before adding event handlers in controller (openshift#1446) 294157d remove setServiceBindingCondition dependency on controller (openshift#1441) 118a0f7 Fix typo in validation (openshift#1447) 117bfbd clean up error logging (openshift#1443) dff470f Move "External" around in some resource names/properties (openshift#1354) 0885edb Adding expectedGot function and using it. (openshift#1440) a7d582e Pretty controller broker (openshift#1442) c5edfaf Set apimachinery build variables with semver info (openshift#1429) 0e90d82 Add a pretty formatter for ClusterService[Class|Plan] (openshift#1408) fb874df Remove deprecated basic auth config support (openshift#1431) f4cd181 Migrate to metav1 methods for manipulating controllerRefs (openshift#1433) 96b286e Make service/plan reference fields on instance spec selectable (openshift#1422) 33f2b04 First example using the pretty context builder. (openshift#1403) 7852917 Stop using corev1.ObjectReference and corev1.LocalObjectReference (openshift#1417) fcf9480 Add tests for plan updates (openshift#1412) 819332e Add root CAs (openshift#1419) b49a76a Clean Makefile a little (openshift#1399) d681da0 Use a separate etcd prefix for each integration test to keep tests isolated (openshift#1415) 314a622 Wire etcd prefix to storage and call complete with options (openshift#1394) REVERT: aa27078754 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: dabde2eb859b5e31e97c01a704561fc27e1848b2
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Oct 24, 2017
…service-catalog/' changes from aa27078754..510060232e 510060232e origin build: add origin tooling de45e94 v0.1.0 chart changes (openshift#1468) 0bb9982 Modify Makefile to only specify ldflags once (openshift#1471) 5d6afac Fixes openshift#735: Add repo-sync script for charts (openshift#1453) 630f13f fix lingering unversioned client API (openshift#1466) 6f49128 Fix several logging errors (openshift#1464) 2aece61 Delete removed serviceClasses when they have no instances left (openshift#1450) 179d302 Uncommenting UID field after updating to k8s 1.8 (openshift#1457) b70c076 Reorder class and plan creation; test plan conflict handling (openshift#1459) 4bea012 Use versioned client APIs (openshift#1458) ff4af30 clean up logic for 410 gone deprovision poll (openshift#1452) 3fddf27 clean up logic and fix message for failed poll (openshift#1451) 40926cd Fix typo from openshift#1354 (openshift#1456) ff86ef2 Delete removed serviceplans when they have no instances left (openshift#1444) 8411a16 tweak binding setAndUpdateOrphanMitigation function (openshift#1448) ce28252 Combine apiserver and controller-manager into a single service-catalog image (openshift#1343) 7bbc8ee Check service class / plan before allowing provisioning or plan changes. (openshift#1439) baf28de Create listers before adding event handlers in controller (openshift#1446) 294157d remove setServiceBindingCondition dependency on controller (openshift#1441) 118a0f7 Fix typo in validation (openshift#1447) 117bfbd clean up error logging (openshift#1443) dff470f Move "External" around in some resource names/properties (openshift#1354) 0885edb Adding expectedGot function and using it. (openshift#1440) a7d582e Pretty controller broker (openshift#1442) c5edfaf Set apimachinery build variables with semver info (openshift#1429) 0e90d82 Add a pretty formatter for ClusterService[Class|Plan] (openshift#1408) fb874df Remove deprecated basic auth config support (openshift#1431) f4cd181 Migrate to metav1 methods for manipulating controllerRefs (openshift#1433) 96b286e Make service/plan reference fields on instance spec selectable (openshift#1422) 33f2b04 First example using the pretty context builder. (openshift#1403) 7852917 Stop using corev1.ObjectReference and corev1.LocalObjectReference (openshift#1417) fcf9480 Add tests for plan updates (openshift#1412) 819332e Add root CAs (openshift#1419) b49a76a Clean Makefile a little (openshift#1399) d681da0 Use a separate etcd prefix for each integration test to keep tests isolated (openshift#1415) 314a622 Wire etcd prefix to storage and call complete with options (openshift#1394) REVERT: aa27078754 origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 510060232e54eb64b294213bb5d7847e169a2fac
jpeeler
pushed a commit
to jpeeler/origin
that referenced
this pull request
Feb 1, 2018
* First example using the log context builder. * No format. * Remote controller logging class, not needed yet. * Fixing cr date. * Adding function documentation. * Kind is always type Kind. * Start of log names. * Add comment for type. * I feel so pretty. Oh so pretty. Pretty log lines. * Move type to it's own file. * Renaming files, fixing receiver names. * Working on an example for Pretty Names for classes that have internal and external names. * Remove old logging file. * Merge. * Finish controller.go. * Fix comment. * finished controller_broker.go as an example. * Fixing unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.