Improve the general message flow for login

[smarterclayton]

@fabianofranz review please

[fabianofranz]

Integration tests use these Gather*Info methods.

[smarterclayton]

Bad integration tests. That's unit territory.

On Mar 23, 2015, at 10:36 PM, Fabiano Franz notifications@github.com wrote:

In pkg/cmd/cli/cmd/loginoptions.go:

@@ -69,13 +69,13 @@ func (o _LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server to make sure we can
// connect to it, and if any problem is found (e.g. certificate issues), ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {
Integration tests use these Gather_Info methods.

—
Reply to this email directly or view it on GitHub.

[fabianofranz]

I agree, we don't use the full GatherInfo test in integration tests at the moment because of an issue with project caching (test assigns a project to user, user's project list does not reflect it right after), so we have to avoid GatherProjectInfo. There's a TODO in test_login to uncomment when the issue is fixed.

----- Original Message -----

@@ -69,13 +69,13 @@ func (o *LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server to
make sure we can
// connect to it, and if any problem is found (e.g. certificate issues),
ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {

Bad integration tests. That's unit territory.

On Mar 23, 2015, at 10:36 PM, Fabiano Franz notifications@github.com
wrote:

In pkg/cmd/cli/cmd/loginoptions.go:

@@ -69,13 +69,13 @@ func (o _LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server to
make sure we can
// connect to it, and if any problem is found (e.g. certificate issues),
ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {
Integration tests use these Gather_Info methods.

—
Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1422/files#r27002506

[smarterclayton]

I don't think these should be exposed since they're implementation detail. Agree it's important to test them, but exposing them was making them seem like reusable function and I don't know that we have a use case for that now.

----- Original Message -----

@@ -69,13 +69,13 @@ func (o *LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server to
make sure we can
// connect to it, and if any problem is found (e.g. certificate issues),
ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {

I agree, we don't use the full GatherInfo test in integration tests at the
moment because of an issue with project caching (test assigns a project to
user, user's project list does not reflect it right after), so we have to
avoid GatherProjectInfo. There's a TODO in test_login to uncomment when
the issue is fixed.

----- Original Message -----

@@ -69,13 +69,13 @@ func (o *LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server to
make sure we can
// connect to it, and if any problem is found (e.g. certificate issues),
ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {

Bad integration tests. That's unit territory.

On Mar 23, 2015, at 10:36 PM, Fabiano Franz notifications@github.com
wrote:

In pkg/cmd/cli/cmd/loginoptions.go:

@@ -69,13 +69,13 @@ func (o _LoginOptions) GatherInfo() error {
// present ask for interactive user input. Will also ping the server
to
make sure we can
// connect to it, and if any problem is found (e.g. certificate
issues),
ask the user about
// connecting insecurely.
-func (o *LoginOptions) GatherServerInfo() error {
Integration tests use these Gather_Info methods.

—
Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1422/files#r27002506

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1422/files#r27003159

[smarterclayton]

@liggitt or @jwforres can you review?

[jwforres]

If you already have a project set during login then you are probably not a first time user so don't dump the list of projects.

[smarterclayton]

[merge] after addressing jessica's comments

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1288/) (Image: devenv-fedora_1127)

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1446/)

[smarterclayton]

[merge]

[smarterclayton]

[merge]

[fabianofranz]

[merge] again

[openshift-bot]

Evaluated for origin up to e6e99d1