Provide easy delete of resources for new-app and generate

[0xmichalis]

No description provided.

[0xmichalis]

@bparees is this enough? Will all the generated resources from this template object have that lbl?

[bparees]

@Kargakis yes i believe if you add an object label to the template before processing it, everything produced from that template will have that label.

[smarterclayton]

I don't think we should do this. We should be able to infer a name from new-app, not generate a random value per client.

[bparees]

it's not just new-app right? "osc create -f myconfiglist.json" also needs labels applied.

[smarterclayton]

No..... don't do that.

----- Original Message -----

• switch len(args) {
• case 2:

•   return map[string]string{args[0]: args[1]}, nil
  

• default:
• }

• return nil, fmt.Errorf("invalid label spec: %s", labelSpec)
  +}

+var (

• mut sync.Mutex
• version int
  +)

+func GetLabel() string {

it's not just new-app right? "osc create -f myconfiglist.json" also needs
labels applied.

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1537/files#r27611732

[smarterclayton]

To clarify, create should only ever create what you send it. No changes.

----- Original Message -----

No..... don't do that.

----- Original Message -----

• switch len(args) {
• case 2:

• return map[string]string{args[0]: args[1]}, nil
  

• default:
• }
  +
• return nil, fmt.Errorf("invalid label spec: %s", labelSpec)
  +}
  +
  +var (
• mut sync.Mutex
• version int
  +)
  +
  +func GetLabel() string {

it's not just new-app right? "osc create -f myconfiglist.json" also needs
labels applied.

---

Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1537/files#r27611732

[0xmichalis]

I had made some comments but force-pushed in the meantime and now they are lost. @smarterclayton ptal. Is the way I am creating aliases what you were suggesting?

[0xmichalis]

Setting up a label in the template object has no affect to its derivatives

[vagrant@openshiftdev sample-app]$ openshift cli process -f application-template-stibuild.json -l name=hello-world | openshift cli create -f -
services/frontend
routes/route-edge
imageStreams/origin-ruby-sample
imageStreams/ruby-20-centos7
buildConfigs/ruby-sample-build
deploymentConfigs/frontend
services/database
deploymentConfigs/database
[vagrant@openshiftdev sample-app]$ openshift cli delete all -l name=hello-world
No resources found
[vagrant@openshiftdev sample-app]$ openshift cli describe services frontend
Name:           frontend
Labels:         template=application-template-stibuild
Selector:       name=frontend
IP:         172.30.97.116
Port:           5432
Endpoints:      <none>
Session Affinity:   None
No events.

[0xmichalis]

[test]

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1773/)

[0xmichalis]

re[test]

[bparees]

lgtm.

[0xmichalis]

@bparees what should we do with osc process? Setting up labels on template objects doesn't work as expected. Should we drop labeling via it altogether?

[bparees]

@Kargakis remind me, what about it doesn't work as expected?

[0xmichalis]

@Kargakis remind me, what about it doesn't work as expected?

See this

[bparees]

@Kargakis why not just added it to the "labels" field of the Template object prior to processing?

// Optional: Labels is a set of labels that are applied to every
// object during the Template to Config transformation
Labels map[string]string json:"labels,omitempty"

In anycase i'm not sure why your existing code isn't working, seems like a bug somewhere.

[0xmichalis]

@Kargakis why not just added it to the "labels" field of the Template object prior to processing?

// Optional: Labels is a set of labels that are applied to every
// object during the Template to Config transformation
Labels map[string]string json:"labels,omitempty"

In anycase i'm not sure why your existing code isn't working, seems like a bug somewhere.

Thanks for your feedback. I'll take a closer look tomorrow.

[0xmichalis]

@bparees the issue about setting up labels in the Template to Config process is fixed now:)
I'll separate my commits to UPSTREAM and non-UPSTREAM, and this is ready for merging.
Except one last thing, the PR on Kubernetes is still not in...

[bparees]

lgtm. [merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1530/) (Image: devenv-fedora_1250)

[openshift-bot]

Evaluated for origin up to 70c2279