Update sample app README to use login and project commands

[fabianofranz]

No description provided.

[fabianofranz]

[merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[smarterclayton]

[merge]

[openshift-bot]

Evaluated for origin up to b84150d

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1677/)

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1677/) (Image: devenv-fedora_1189)

[soltysh]

This is very unfortunate PR, since osc build-logs won't work with this change, see:

[vagrant@openshiftdev origin]$ osc build-logs ruby-sample-build-1
{
  "kind": "Status",
  "creationTimestamp": null,
  "apiVersion": "v1beta1",
  "status": "Failure",
  "message": "\"/osapi/v1beta1/proxy/buildLogs/ruby-sample-build-1?namespace=test\" is forbidden because test-admin cannot proxy on buildLogs with name \"ruby-sample-build-1\" in test",
  "reason": "Forbidden",
  "details": {},
  "code": 403
}

[fabianofranz]

@soltysh Seems you are testing with Vagrant, correct? The complete process worked fine with a simple build from source, so let me check it it's related to Vagrant only.

[soltysh]

Correct, it was on vagrant. For the discussion around the problems with
build logs after logging in you can have a look at my PR #1549.

On 5:03pm, Mon, Apr 6, 2015 Fabiano Franz notifications@github.com wrote:

@soltysh https://github.com/soltysh Seems you are testing with Vagrant,
correct? The complete process worked fine with a simple build from source,
so let me check it it's related to Vagrant only.

—
Reply to this email directly or view it on GitHub
#1553 (comment).

[fabianofranz]

@soltysh Confirmed the issue (outside vagrant).

@smarterclayton @bparees The use of osc login breaks the osc build-logs part of sample app's flow in README because now only cluster admins are allowed to proxy (related discussion in #1549). Should we revert the use of login here for now, or leave it as is until build logs get moved?

[bparees]

@fabianofranz yes we should definitely revert this and in the future if we're adding commands to the readme, they should be added to the e2e steps at the same time (which would have caught this issue)

[soltysh]

+1

On 9:53pm, Mon, Apr 6, 2015 Ben Parees notifications@github.com wrote:

@fabianofranz https://github.com/fabianofranz yes we should definitely
revert this and in the future if we're adding commands to the readme, they
should be added to the e2e steps at the same time (which would have caught
this issue)

—
Reply to this email directly or view it on GitHub
#1553 (comment).

[fabianofranz]

@bparees This was on e2e already, but was part of a separate PR merged before docs. I'll make sure it's in the same PR in future.

Actually instead of reverting everything in README we can just run the build-logs command as cluster admin, and keep everything else as is. It's in fact what e2e is doing since 16df0e8. I'll open a PR with the change.

[fabianofranz]

@bparees @soltysh #1617

[bparees]

Sounds good. Thanks! 

Ben Parees | OpenShift

From: Fabiano Franz notifications@github.com
Sent: Apr 6, 2015 4:57 PM
To: openshift/origin
Cc: Ben Parees
Subject: Re: [origin] Update sample app README to use login and project commands (#1553)

@bparees This was on e2e already, but was part of a separate PR merged before docs. I'll make sure it's in the same PR in future.

Actually instead of reverting everything in README we can just run the build-logs command as cluster admin, and keep everything else as is. It's in fact what e2e is doing since 16df0e8. I'll open a PR with the change.

---

Reply to this email directly or view it on GitHub:
#1553 (comment)

[soltysh]

@fabianofranz that's even better, thx for doing this 👍