Updated sample-app output to match current state of work#1549
Updated sample-app output to match current state of work#1549openshift-bot merged 1 commit intoopenshift:masterfrom
Conversation
|
@soltysh this is handled in e2e via: you'd want to do something similar here. also e2e should be updated to do an osc login if it is not currently doing so. |
|
Only cluster admins are allowed to proxy, so only cluster admins can see the build logs. @liggitt this was a side effect of securing the node, correct? |
|
@deads2k correct |
|
once build logs move under namespaces/[ns]/builds/[build]/logs, we can grant access to project admins |
|
thought we were still doing redirect to the kubelet for logs, did that change? |
|
changed when the node got secured |
|
ok, so we can't add osc login to the steps for now (since it prevents build-logs) |
|
(oops, didn't mean to close, some of the other edits in here are useful) |
5266f98 to
ce50eea
Compare
|
@bparees removed the |
|
lgtm. [merge] |
|
[Test]ing while waiting on the merge queue |
ce50eea to
bda8e88
Compare
|
Evaluated for origin up to bda8e88 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1655/) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1655/) (Image: devenv-fedora_1188) |
@bparees PTAL
There's one small problem with my modifications (specifically after adding
osc login), though. I can't see build-logs:@deads2k could you tell me what role should I assign to test-admin so that he has access to it?