Skip to content

Updated sample-app output to match current state of work#1549

Merged
openshift-bot merged 1 commit intoopenshift:masterfrom
soltysh:update_sample_app_readme
Apr 2, 2015
Merged

Updated sample-app output to match current state of work#1549
openshift-bot merged 1 commit intoopenshift:masterfrom
soltysh:update_sample_app_readme

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 1, 2015

@bparees PTAL
There's one small problem with my modifications (specifically after adding osc login), though. I can't see build-logs:

[vagrant@openshiftdev origin]$ osc build-logs ruby-sample-build-1 -n test
{
  "kind": "Status",
  "creationTimestamp": null,
  "apiVersion": "v1beta1",
  "status": "Failure",
  "message": "\"/osapi/v1beta1/proxy/buildLogs/ruby-sample-build-1?namespace=test\" is forbidden because test-admin cannot proxy on buildLogs with name \"ruby-sample-build-1\" in test",
  "reason": "Forbidden",
  "details": {},
  "code": 403
}

@deads2k could you tell me what role should I assign to test-admin so that he has access to it?

@bparees
Copy link
Contributor

bparees commented Apr 1, 2015

@soltysh this is handled in e2e via:
openshift ex new-project test --description="This is an example project to demonstrate OpenShift v3" --admin="anypassword:e2e-user"

you'd want to do something similar here.

also e2e should be updated to do an osc login if it is not currently doing so.

@deads2k
Copy link
Contributor

deads2k commented Apr 1, 2015

Only cluster admins are allowed to proxy, so only cluster admins can see the build logs.

@liggitt this was a side effect of securing the node, correct?

@liggitt
Copy link
Contributor

liggitt commented Apr 1, 2015

@deads2k correct

@liggitt
Copy link
Contributor

liggitt commented Apr 1, 2015

once build logs move under namespaces/[ns]/builds/[build]/logs, we can grant access to project admins

@bparees
Copy link
Contributor

bparees commented Apr 1, 2015

thought we were still doing redirect to the kubelet for logs, did that change?

@liggitt
Copy link
Contributor

liggitt commented Apr 1, 2015

changed when the node got secured

@bparees
Copy link
Contributor

bparees commented Apr 1, 2015

ok, so we can't add osc login to the steps for now (since it prevents build-logs)

@bparees bparees closed this Apr 1, 2015
@bparees bparees reopened this Apr 1, 2015
@bparees
Copy link
Contributor

bparees commented Apr 1, 2015

(oops, didn't mean to close, some of the other edits in here are useful)

@soltysh soltysh force-pushed the update_sample_app_readme branch from 5266f98 to ce50eea Compare April 1, 2015 19:31
@soltysh
Copy link
Contributor Author

soltysh commented Apr 1, 2015

@bparees removed the osc login step, all the rest is as it was.

@bparees
Copy link
Contributor

bparees commented Apr 1, 2015

lgtm. [merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@soltysh soltysh force-pushed the update_sample_app_readme branch from ce50eea to bda8e88 Compare April 2, 2015 11:07
@openshift-bot
Copy link
Contributor

Evaluated for origin up to bda8e88

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1655/)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1655/) (Image: devenv-fedora_1188)

openshift-bot pushed a commit that referenced this pull request Apr 2, 2015
@openshift-bot openshift-bot merged commit 6e39fb2 into openshift:master Apr 2, 2015
@soltysh soltysh deleted the update_sample_app_readme branch April 8, 2015 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants