stop running the TSB in the main apiserver #15684
Conversation
openshift-merge-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
@jim-minter can you confirm that these are the only two tests that require it to be enabled? |
|
@deads2k Correct. |
|
don't know if there's more coming but lgtm so far |
I've got to start using the templates and move these tests into the normal conformance bucket. Then this will be ready. |
deads2k
changed the title
deads2k
force-pushed
the
tsb-11-removeconfig
branch
2 times, most recently
from
fd25d22 to
3afbf2d
Compare
|
@jim-minter please take another look. I've remove more dead code. |
openshift-merge-robot
added
the
needs-rebase
|
Will it be possible for templateServiceBrokerConfig be removed from pkg/cmd/server/api/v1/types.go? Is this the point at which it can happen? If so, doing a grep -r templateServiceBrokerConfig and fix-up would be good. |
|
otherwise still lgtm |
It's on my list, but on my list to do separately. I'm not completely sure what will happen to the installer if I do it. |
deads2k
force-pushed
the
tsb-11-removeconfig
branch
from
3afbf2d to
7c31b75
Compare
openshift-merge-robot
removed
the
needs-rebase
|
prereqs have merged. tagging |
deads2k
added
lgtm
deads2k
force-pushed
the
tsb-11-removeconfig
branch
from
7c31b75 to
40878a9
Compare
openshift-merge-robot
removed
the
lgtm
deads2k
force-pushed
the
tsb-11-removeconfig
branch
from
40878a9 to
b2f1bff
Compare
deads2k
added
lgtm
|
/retest |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue (batch tested with PRs 15719, 15761) moves the TSB into its own package This moves all TSB code into its own package. The only references we have to this code are here: ``` ./pkg/cmd/server/start/start_allinone.go ./pkg/cmd/server/origin/master.go ./test/extended/templates/templateservicebroker_security.go ./test/extended/templates/templateservicebroker_e2e.go ``` We're going to remove the `master.go` reference in #15684, leaving a dependency on building the command and in the e2e tests. @smarterclayton @sttts Are we ready to jump off the cliff and move to staging repos? We'd end up with cyclical imports until we sort out openshift/client-go#2, but that looks tractable for an internal solution in 3.7 so we can learn how we want to shape it....
4 participants
The last commit here stops serving the TSB from the apiserver. I'm expecting failures, so this is flushing them out for me.
I've left the types to do separately in case it breaks the patch command used elsewhere to add this to the config.