Attempt to start #2
Conversation
|
I think we want to support go get to a degree |
|
In the sense that there's a reason people want to do go get. I'm less worried about internal clients - I think evidence from upstream is that only a small subset of people needed them. |
|
About 1: I don't care much about go-get'ability. But I care about integrating this into other projects. The procedure for kube/client-go (compare https://github.com/kubernetes/client-go/issues/259#issuecomment-320320158) is
Does this work with glide? Masterminds/glide#366 suggests it doesn't. |
| - external/github.com/docker/docker/pkg/archive | ||
| - external/github.com/docker/docker/pkg/fileutils | ||
| - external/github.com/docker/docker/pkg/homedir | ||
| - external/github.com/docker/docker/pkg/idtools |
There was a problem hiding this comment.
omg, we vendored the whole universe.
There was a problem hiding this comment.
we should find why we need those and make issues to improve our code hygiene for those in corresponding teams :)
hack/update-generated-clientset.sh
Outdated
| @@ -0,0 +1,36 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I am not a fan of these 50 liner bash scripts in every projects right now. But it's the best we have right now :-/
There was a problem hiding this comment.
Can we call it update-codegen.sh at least?
hack/update-generated-clientset.sh
Outdated
| @@ -0,0 +1,36 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
#!/bin/bash -e for proper error handling.
Automatic merge from submit-queue (batch tested with PRs 15719, 15761) moves the TSB into its own package This moves all TSB code into its own package. The only references we have to this code are here: ``` ./pkg/cmd/server/start/start_allinone.go ./pkg/cmd/server/origin/master.go ./test/extended/templates/templateservicebroker_security.go ./test/extended/templates/templateservicebroker_e2e.go ``` We're going to remove the `master.go` reference in #15684, leaving a dependency on building the command and in the e2e tests. @smarterclayton @sttts Are we ready to jump off the cliff and move to staging repos? We'd end up with cyclical imports until we sort out openshift/client-go#2, but that looks tractable for an internal solution in 3.7 so we can learn how we want to shape it....
deads2k
force-pushed
the
start-02-glide
branch
from
b099a76 to
41148cf
Compare
|
How about this as a starting point and after it merges I enable travis and we go from there? |
|
As long as we leave the "Not ready yet" in the readme, lgtm. |
Definitely will. Merging this to build on . |
|
👍 |
1 similar comment
|
👍 |
add controller package
5 participants
This is an attempt using glide. I've managed to generate building code, so that's nice.
I used glide to handle the vendor dir, but I'm unsure how repeatable it really is.
The clients are under
<group>/{internalclientset,clientset,informers,listers}@liggitt @sttts @smarterclayton let's argue about:
go get-ability. I don't, vendor or you aren't repeatable and if you aren't repeatable, then I don't feel too bad about weird things happening