Only build pkg/sdn/plugin on linux

[danwinship]

We are currently building (most of) the SDN code on Darwin and Windows, even though it is totally linux-specific.

I ran into this when trying to make more use of the "netlink" library in the sdn code (#15834). The library only builds on linux, so any file that imports it has to also be only built on linux.

So this tries to fix the main openshift binary to only include the SDN code when building on Linux. I don't know if it's correct stylistically. I'm happy to rewrite it however.

@openshift/networking FYI

[smarterclayton]

Yay, build-cross got triggered automatically. So happy

[danwinship]

OK, cross-build succeeded. Other failures look like flakes.

I had to tweak hack/import-restrictions.json to get "make verify" to pass, and probably that should be fixed differently. I guess one approach would be to move the SDNNode and SDNProxy interfaces into a new directory (neither pkg/sdn/plugin nor pkg/sdn/apis) so we can keep pkg/sdn/apis pure?

[smarterclayton]

I think this won't be allowed - @deads2k for his goals here

[deads2k]

I think this won't be allowed - @deads2k for his goals here

Our api packages should only be for the type definitions themselves. We're going to build a client-go library for openshift (see attempts here: openshift/client-go#2) and the dependencies for that library need to be reasonable. Our API types are required, but the interfaces which make them more useable for runtime purposes aren't generally needed by the client, so they should live a separate package.

[danwinship]

/retest
after revert of bad commit to master

[danwinship]

/retest

[danwinship]

/retest

[danwinship]

flake #14385
/test extended_networking_minimal
/test extended_networking

[danwinship]

All tests pass now
@smarterclayton ok now? I moved the OpenShift-internal SDN interfaces to the top level of pkg/sdn to get rid of the extra imports in pkg/sdn/apis/network

[deads2k]

Glad to see the move to start slimming down the package

/approve

lgtm if it's basically a straight move

[deads2k]

/lgtm

[openshift-merge-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, deads2k

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• pkg/cmd/OWNERS [deads2k]
• pkg/diagnostics/OWNERS [deads2k]
• pkg/oc/OWNERS [deads2k]
• pkg/sdn/OWNERS [danwinship,deads2k]
• test/integration/OWNERS [danwinship,deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[danwinship]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 15904, 15962, 15838, 15965, 15963)