Skip to content

Conversation

@jim-minter
Copy link
Contributor

fixes #16383

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jim-minter
We suggest the following additional approver: bparees

Assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Sep 16, 2017

@jim-minter did you test this w/ the web console? I was actually working on a PR for this myself this afternoon (Whoops, bad communication) and I think the structure is a little different (I had to ask @spadgett about it).

here's my branch:
bparees@9807587

(I didn't open the PR because i'm not happy w/ the new types i'm introducing yet and wanted to play w/ it some more, but I did at least see that it set the ordering correctly in the web console).

@jim-minter
Copy link
Contributor Author

Closed in favour of #16416

@jim-minter jim-minter closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-api-review size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template service broker can specify parameter ordering

4 participants