provide a specific order for template parameters in the TSB #16416

bparees · 2017-09-18T17:05:19Z

fixes #16383

bparees · 2017-09-18T17:38:49Z

@jim-minter updated, ptal.

bparees · 2017-09-18T17:53:23Z

@jim-minter ok now this is ready for review.

bparees · 2017-09-18T17:53:46Z

/unassign @smarterclayton
/unassign @mfojtik
/assign @jim-minter

jim-minter · 2017-09-18T18:10:13Z

pkg/templateservicebroker/openservicebroker/api/types.go

+}
+
+type ParameterSchema struct {
+	Create map[string]interface{} `json:"create,omitempty"`


you don't want to make Create of type struct {
OpenShiftFormDefinition []string json:"openshift_form_definition,omitempty"
}
?

I guess that would make sense :)

jim-minter

2 nits then lgtm

jim-minter · 2017-09-18T19:03:33Z

pkg/templateservicebroker/servicebroker/catalog.go


 	noDescriptionProvided = "No description provided."
+
+	openshiftFormDefinitionKey = "openshift_form_definition"


now superfluous

jim-minter · 2017-09-18T19:05:05Z

pkg/templateservicebroker/openservicebroker/api/types.go

 	Create map[string]*jsschema.Schema `json:"create,omitempty"`
 }

+type ParameterSchemas struct {


comment that this is an OpenShift extension

bparees · 2017-09-18T19:12:17Z

done.

…

On Mon, Sep 18, 2017 at 3:06 PM, Jim Minter ***@***.***> wrote: ***@***.**** commented on this pull request. 2 nits then lgtm ------------------------------ In pkg/templateservicebroker/servicebroker/catalog.go <#16416 (comment)>: > @@ -20,6 +20,8 @@ const ( requesterUsernameDescription = "OpenShift user requesting provision/bind" noDescriptionProvided = "No description provided." + + openshiftFormDefinitionKey = "openshift_form_definition" now superfluous ------------------------------ In pkg/templateservicebroker/openservicebroker/api/types.go <#16416 (comment)>: > @@ -59,6 +59,18 @@ type ServiceBindings struct { Create map[string]*jsschema.Schema `json:"create,omitempty"` } +type ParameterSchemas struct { comment that this is an OpenShift extension — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16416 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3iPOC-kA0kAmqMQ93UG_b0LfdZuNks5sjr9KgaJpZM4PbOdK> .

-- Ben Parees | OpenShift

bparees · 2017-09-18T21:17:38Z

/retest

jim-minter · 2017-09-18T21:34:20Z

/lgtm

openshift-merge-robot · 2017-09-18T21:34:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~pkg/OWNERS~~ [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

bparees · 2017-09-19T01:41:05Z

/retest

…

On Mon, Sep 18, 2017 at 9:17 PM, OpenShift CI Robot < ***@***.***> wrote: @bparees <https://github.com/bparees>: The following test *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/cmd 1c63241 <1c63241> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16416/test_pull_request_origin_cmd/3023/> /test cmd Full PR test history <https://openshift-gce-devel.appspot.com/pr/16416>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/bparees>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://github.com/kubernetes/test-infra/blob/master/commands.md>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16416 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEvl3pWz4mKywVmQl7VfZexyuXmvjRwfks5sjxYzgaJpZM4PbOdK> .

-- Ben Parees | OpenShift

openshift-merge-robot · 2017-09-19T02:27:02Z

Automatic merge from submit-queue

bparees · 2017-09-19T14:23:05Z

@gabemontero fyi this PR added another reference to the username parameter that will need to be removed in your PR.

openshift-merge-robot assigned mfojtik and smarterclayton Sep 18, 2017

openshift-merge-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-api-review labels Sep 18, 2017

openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2017

jim-minter mentioned this pull request Sep 18, 2017

Template service broker can specify parameter ordering #16391

Closed

bparees force-pushed the ordering branch from e88777d to 1e59cb5 Compare September 18, 2017 17:38

openshift-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 18, 2017

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2017

bparees force-pushed the ordering branch from 1e59cb5 to 3017c7d Compare September 18, 2017 17:49

openshift-ci-robot assigned jim-minter and unassigned mfojtik and smarterclayton Sep 18, 2017

jim-minter reviewed Sep 18, 2017

View reviewed changes

bparees force-pushed the ordering branch from 3017c7d to 6d2211b Compare September 18, 2017 18:37

jim-minter reviewed Sep 18, 2017

View reviewed changes

provide a specific order for template parameters in the TSB

1c63241

bparees force-pushed the ordering branch from 6d2211b to 1c63241 Compare September 18, 2017 19:11

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2017

openshift-merge-robot merged commit b76b0a9 into openshift:master Sep 19, 2017

bparees deleted the ordering branch September 22, 2017 03:55


		noDescriptionProvided = "No description provided."

		openshiftFormDefinitionKey = "openshift_form_definition"

provide a specific order for template parameters in the TSB #16416

provide a specific order for template parameters in the TSB #16416

Uh oh!

Conversation

bparees commented Sep 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented Sep 18, 2017

Uh oh!

bparees commented Sep 18, 2017

Uh oh!

bparees commented Sep 18, 2017

Uh oh!

jim-minter Sep 18, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Sep 18, 2017

Choose a reason for hiding this comment

Uh oh!

bparees Sep 18, 2017

Choose a reason for hiding this comment

Uh oh!

jim-minter left a comment

Choose a reason for hiding this comment

Uh oh!

jim-minter Sep 18, 2017

Choose a reason for hiding this comment

Uh oh!

jim-minter Sep 18, 2017

Choose a reason for hiding this comment

Uh oh!

bparees commented Sep 18, 2017 via email

Uh oh!

bparees commented Sep 18, 2017

Uh oh!

jim-minter commented Sep 18, 2017

Uh oh!

openshift-merge-robot commented Sep 18, 2017

Uh oh!

bparees commented Sep 19, 2017 via email

Uh oh!

openshift-merge-robot commented Sep 19, 2017

Uh oh!

bparees commented Sep 19, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bparees commented Sep 18, 2017 •

edited

Loading