Disable wildcard dns extended test #21406
Conversation
openshift-ci-robot
added
the
size/XS
|
@openshift/sig-network-edge PTAL |
|
@smarterclayton is it correct that we need this test to continue working as-is against 3.x Ansible-installed clusters? If so, I can think of a couple ways to make sure the suite passes against both:
Other ways/thoughts? |
|
Did we get the necessary approval to break backwards compatibility for this
feature by verifying customers weren’t affected, measuring the cost to
support it, what workarounds exist? Or are you asking about temporary
disablement?
On Nov 1, 2018, at 1:57 PM, Dan Mace <notifications@github.com> wrote:
@smarterclayton <https://github.com/smarterclayton> is it correct that we
need this test to continue working as-is against 3.x Ansible-installed
clusters? If so, I can think of a couple ways to make sure the suite passes
against both:
1. Add stuff to the test to skip when we detect 4.0 router
2. Actively skip the unsupported test in the operator CI config
Other ways/thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21406 (comment)>,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8Qhn4p5nX2P7c6VkeF9RNn5XEnWks5uqzYggaJpZM4YHWzd>
.
|
Just temporary. |
test/extended/dns/dns.go
Outdated
| f := e2e.NewDefaultFramework("dns") | ||
|
|
||
| It("should answer endpoint and wildcard queries for the cluster [Conformance]", func() { | ||
| Skip("TODO: re-enable when wildcard dns queries are supported by openshift dns operator") |
There was a problem hiding this comment.
Instead of changing it here, add this to test/extended/util/test.go and add it to the section on broken tests with a link to the enablement.
No one should be adding Skip rules to their tests.
There was a problem hiding this comment.
edit: unless they are conditional skips (this isn't conditional)
pravisankar
force-pushed
the
skip-dns-wildcard-test
branch
from
17eb31e to
d957353
Compare
pravisankar
changed the title
|
@ironcladlou @smarterclayton updated, PTAL |
| local skip="\[Serial\]" | ||
| if [[ -n "${SKIP:-}" ]]; then | ||
| skip+="|${SKIP}" | ||
| fi |
There was a problem hiding this comment.
This seems to imply there was a bug of some sort?
There was a problem hiding this comment.
Yes, without this fix, ginko command will be:
ginkgo -v -noColor -focus=DNS -skip=\[Disabled:.+\]|\[Disruptive\]|\[Skipped\]|\[Slow\]|\[Flaky\]|\[local\]|\[Local\] -p -nodes=5 os::util::find::built_binary extended.test -- -ginkgo.skip \[Serial\] -test.timeout 6h
Later ginkgo.skip option overrides the former -skip option and we do see execution of wildcard dns queries that has [Disabled:Broken] tag.
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
test/extended/setup.sh
Outdated
| # first run anything that isn't explicitly declared [Serial], and matches the $FOCUS, in a parallel mode. | ||
| os::log::info "Running parallel tests N=${PARALLEL_NODES:-<default>} with focus ${FOCUS}" | ||
| TEST_REPORT_FILE_NAME=focus_parallel TEST_PARALLEL="${PARALLEL_NODES:-5}" os::test::extended::run -- -ginkgo.skip "\[Serial\]" -test.timeout 6h ${TEST_EXTENDED_ARGS-} || exitstatus=$? | ||
| TEST_REPORT_FILE_NAME=focus_parallel TEST_PARALLEL="${PARALLEL_NODES:-5}" os::test::extended::run -- -ginkgo.skip ${skip} -test.timeout 6h ${TEST_EXTENDED_ARGS-} || exitstatus=$? |
There was a problem hiding this comment.
Would be good to wrap ${skip} in double-quotes in case the user specifies a value with spaces.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
- Currently not supported by openshift dns operator This functionality is needed to ensure backward compatibility.
pravisankar
force-pushed
the
skip-dns-wildcard-test
branch
from
d957353 to
86c095d
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
7 participants
Currently not supported by openshift dns operator
This functionality is needed to ensure backward compatibility.
Extended tests should honor SKIP env when FOCUS env is set