Skip to content

Conversation

@pravisankar
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2018
@pravisankar
Copy link
Author

/hold
Depends on openshift/origin#21406 (not yet merged)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2018
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2018
@pravisankar
Copy link
Author

/hold cancel
PR openshift/origin#21406 got merged

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2018
from: src
- as: e2e-aws
commands: TEST_FOCUS='should provide DNS for the cluster' run-tests
commands: TEST_FOCUS='DNS' TEST_SKIP='(\[Disabled:.+\]|\[Disruptive\]|\[Skipped\]|\[Slow\]|\[Flaky\]|\[local\]|\[Local\])'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarterclayton Should these skips be necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need at least [Disabled:.+] option to skip the wildcard dns test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that problematic tests are skipped internally in the extended test setup code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I see the problem now. Only tests who don't match the exclusion list get the suite conformance tags added to them: https://github.com/openshift/origin/blob/master/test/extended/util/test.go#L117

But I think if you're using TEST_FOCUS the internal exclusion list doesn't matter. I still feel like there must be some other way to specify a focus but also use the exclusion list.

Unless @smarterclayton or @stevekuznetsov knows what to do here I say we merge it and revisit.

@ironcladlou
Copy link
Contributor

Let's merge this and refactor when we figure out how to avoid the skip stuff.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2018
@ironcladlou
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ironcladlou, pravisankar
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: droslean

If they are not already assigned, you can assign the PR to them by writing /assign @droslean in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou
Copy link
Contributor

Not entirely sure why this isn't auto-approved based on OWNERS... @smarterclayton @stevekuznetsov ?

@smarterclayton
Copy link
Contributor

/hold

This is going to be replaced by the smoke suite. I expect it to merge tonight or tomorrow morning, at which point all the DNS tests should be added in to the smoke suite

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2018
@petr-muller
Copy link
Member

petr-muller commented Nov 13, 2018

Not entirely sure why this isn't auto-approved based on OWNERS... @smarterclayton @stevekuznetsov ?

@ironcladlou, seems because all affected files do not share an approver who might approve them all, so root OWNERS is effective:

$ cat $( find ci-operator/ -name OWNERS | grep -e 'cluster-dns-operator' -e '/coredns/' )
(...pruned comments and reviewers for clarity...)
approvers:
- chrisohaver
- johnbelamaric
- miekg
- yongtang

approvers:
- ironcladlou
- knobunc

approvers:
- chrisohaver
- johnbelamaric
- miekg
- yongtang

approvers:
- ironcladlou
- knobunc

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2018
@openshift-ci-robot
Copy link
Contributor

@pravisankar: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pravisankar
Copy link
Author

Replaced by smoke suite.

@pravisankar pravisankar closed this Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants