-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable extended DNS e2e tests #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/hold |
85706c9 to
1d5497a
Compare
|
/hold cancel |
| from: src | ||
| - as: e2e-aws | ||
| commands: TEST_FOCUS='should provide DNS for the cluster' run-tests | ||
| commands: TEST_FOCUS='DNS' TEST_SKIP='(\[Disabled:.+\]|\[Disruptive\]|\[Skipped\]|\[Slow\]|\[Flaky\]|\[local\]|\[Local\])' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarterclayton Should these skips be necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need at least [Disabled:.+] option to skip the wildcard dns test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that problematic tests are skipped internally in the extended test setup code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I see the problem now. Only tests who don't match the exclusion list get the suite conformance tags added to them: https://github.com/openshift/origin/blob/master/test/extended/util/test.go#L117
But I think if you're using TEST_FOCUS the internal exclusion list doesn't matter. I still feel like there must be some other way to specify a focus but also use the exclusion list.
Unless @smarterclayton or @stevekuznetsov knows what to do here I say we merge it and revisit.
|
Let's merge this and refactor when we figure out how to avoid the skip stuff. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ironcladlou, pravisankar If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Not entirely sure why this isn't auto-approved based on OWNERS... @smarterclayton @stevekuznetsov ? |
|
/hold This is going to be replaced by the smoke suite. I expect it to merge tonight or tomorrow morning, at which point all the DNS tests should be added in to the smoke suite |
@ironcladlou, seems because all affected files do not share an approver who might approve them all, so root |
|
@pravisankar: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Replaced by smoke suite. |
No description provided.