Skip to content

release: Generate a manifest if the name is semantic #21569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 4, 2018
Merged

release: Generate a manifest if the name is semantic #21569

openshift-merge-robot merged 1 commit into from
Dec 4, 2018

Conversation

@smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Nov 28, 2018

Try to create the metadata if possible. Also update the name on
disk from 'cincinnati' to 'release-metadata'.

@crawford

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 28, 2018
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 28, 2018

/retest

@smarterclayton smarterclayton mentioned this pull request Nov 29, 2018
Merged
@crawford
Copy link
Contributor

crawford commented Nov 29, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor

crawford commented Nov 29, 2018

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 29, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Nov 30, 2018

/retest

@crawford
Copy link
Contributor

crawford commented Nov 30, 2018

/sacrifice-to-the-CI-gods

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 1, 2018

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2018
@smarterclayton
release: Generate a manifest if the name is semantic
da838a2 
Try to create the metadata if possible. Also update the name on
disk from 'cincinnati' to 'release-metadata'.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 1, 2018

Crap, the CVO isn’t ignoring the new name. Have to do that Pr first

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2018
@smarterclayton smarterclayton mentioned this pull request Dec 1, 2018
Merged
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 1, 2018

Opened
openshift/cluster-version-operator#64 which uses the new name and also ignores files that aren't yaml/yml/json.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 3, 2018

/retest

now that 64 is merged

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 3, 2018

/retest

@smarterclayton smarterclayton removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 3, 2018

/retest

3 similar comments
@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 4, 2018

/retest

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 4, 2018

/retest

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Dec 4, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3f0c25c into openshift:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smarterclayton @crawford @openshift-bot @openshift-ci-robot @openshift-merge-robot