React to degraded condition change and bump API so upgrade can handle Force#22644
Merged
smarterclayton merged 3 commits intoopenshift:masterfrom Apr 24, 2019
Merged
React to degraded condition change and bump API so upgrade can handle Force#22644smarterclayton merged 3 commits intoopenshift:masterfrom
smarterclayton merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
smarterclayton
force-pushed
the
bump_upgrade
branch
2 times, most recently
from
9fbb882 to
5d748da
Compare
smarterclayton
force-pushed
the
bump_upgrade
branch
from
5d748da to
63130eb
Compare
soltysh
approved these changes
Apr 24, 2019
| - package: k8s.io/kube-openapi | ||
| repo: https://github.com/openshift/kube-openapi.git | ||
| version: origin-4.0-kubernetes-master-d7c86cd # bumped to match k8s version we've had and then additionally with changes for openapi CRD (we should pick that back around k8s 1.14) | ||
| - package: k8s.io/klog |
Contributor
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
wking
added a commit
to wking/oc
that referenced
this pull request
Aug 17, 2021
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191
wking
added a commit
to wking/oc
that referenced
this pull request
Aug 17, 2021
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 16, 2021
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Feb 9, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Feb 9, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Oct 19, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 15, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 15, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 15, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 15, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 15, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 16, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 17, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 17, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
wking
added a commit
to wking/oc
that referenced
this pull request
Nov 17, 2022
cae0b5e (React to degraded condition change, 2019-04-23, openshift/origin#22644) moved this code from Failing to Degraded, likely inspired by [1]. But Degraded is only used in ClusterOperator. ClusterVersion kept using Failing, as seen in [2]. This commit returns us to watching for Failing (the condition the CVO has been setting the whole time), and informing the caller for any non-happy statuses (or the lack of a Failing condition at all). Even though the issue causing `Failing=True` may block the current update from progressing, it should not block admins from requesting a new update target. For some bugs, retargeting is the recommended way to resolve the issue that is currently sticking the update [3]. [1]: openshift/api#287 [2]: openshift/cluster-version-operator#191 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1988576#c30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gates signing our payloads which is a GA blocker (we have to have a way to bypass upgrades in CLI first).