Upgrading with --force should set the force boolean#22645
Upgrading with --force should set the force boolean#22645smarterclayton merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
size/XXL
|
/assign @abhinavdahiya But #22644 I need to verify has the correct diffs |
smarterclayton
force-pushed
the
set_force
branch
4 times, most recently
from
dc89065 to
7715fea
Compare
smarterclayton
force-pushed
the
set_force
branch
from
7715fea to
429521d
Compare
openshift-ci-robot
added
size/XS
|
/lgtm /test e2e-aws-upgrade |
|
/retest |
|
/test e2e-aws-upgrade |
|
/lgtm |
|
@smarterclayton: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We've been forcing since 429521d (Upgrading with --force should set the force boolean, 2019-03-23, openshift#22645). Back then we were maybe not signing CI releases then? We're currently trusting (and hopefully signing) CI releases with a CI key, and signing nightlies with the beta 2 or release keys [1]. Blocking nightly -> CI updates would be good, and we don't need to run those jobs. CI -> nightly updates would be allowed if we landed something like [2], but we can also get by without any update jobs connecting CI and nightly trust. [1]: https://github.com/openshift/cluster-update-keys/blob/41d14d4c27e274b236426ef80d2144cf46ded532/Makefile#L4-L25 [2]: openshift/cluster-update-keys#16
3 participants
As part of adding certificate verification to the payload we must now
tell the CVO to bypass certain failing conditions. Wire --force to
force and mark that upgrade is not experimental for 4.1.
First two commits from #22644