Skip to content

test/e2e/upgrade: Do not force updates#26073

Closed
wking wants to merge 1 commit intoopenshift:masterfrom
wking:do-not-force-updates
Closed

test/e2e/upgrade: Do not force updates#26073
wking wants to merge 1 commit intoopenshift:masterfrom
wking:do-not-force-updates

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Apr 13, 2021

We've been forcing since 429521d (#22645). Back then we were maybe not signing CI releases then? We're currently trusting (and hopefully signing) CI releases with a CI key, and signing nightlies with the beta 2 or release keys. Blocking nightly -> CI updates would be good, and we don't need to run those jobs. CI -> nightly updates would be allowed if we landed something like openshift/cluster-update-keys#16, but we can also get by without any update jobs connecting CI and nightly trust.

We've been forcing since 429521d (Upgrading with --force should set
the force boolean, 2019-03-23, openshift#22645).  Back then we were maybe not
signing CI releases then?  We're currently trusting (and hopefully
signing) CI releases with a CI key, and signing nightlies with the
beta 2 or release keys [1].  Blocking nightly -> CI updates would be
good, and we don't need to run those jobs.  CI -> nightly updates
would be allowed if we landed something like [2], but we can also get
by without any update jobs connecting CI and nightly trust.

[1]: https://github.com/openshift/cluster-update-keys/blob/41d14d4c27e274b236426ef80d2144cf46ded532/Makefile#L4-L25
[2]: openshift/cluster-update-keys#16
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 25, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-serial 011a695 link /test e2e-aws-serial
ci/prow/e2e-aws-fips 011a695 link /test e2e-aws-fips
ci/prow/e2e-aws-csi 011a695 link /test e2e-aws-csi
ci/prow/e2e-metal-ipi-ovn-ipv6 011a695 link /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp 011a695 link /test e2e-gcp
ci/prow/e2e-gcp-upgrade 011a695 link /test e2e-gcp-upgrade
ci/prow/e2e-gcp-csi 011a695 link /test e2e-gcp-csi
ci/prow/e2e-gcp-disruptive 011a695 link /test e2e-gcp-disruptive
ci/prow/e2e-aws-disruptive 011a695 link /test e2e-aws-disruptive
ci/prow/e2e-agnostic-cmd 011a695 link /test e2e-agnostic-cmd
ci/prow/e2e-aws-jenkins 011a695 link /test e2e-aws-jenkins

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 24, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this Nov 23, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 23, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants