Skip to content

skip node lease until we get kubelet 1.14 in RHCOS#22856

Closed
soltysh wants to merge 1 commit intoopenshift:masterfrom
soltysh:node_lease
Closed

skip node lease until we get kubelet 1.14 in RHCOS#22856
soltysh wants to merge 1 commit intoopenshift:masterfrom
soltysh:node_lease

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented May 18, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2019
@soltysh soltysh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 18, 2019

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 020afc2 link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented May 18, 2019

/hold

Insufficient to cover runtimeclass

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented May 18, 2019

Replaced by #22857

@soltysh soltysh deleted the node_lease branch May 20, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@soltysh @openshift-ci-robot @smarterclayton