Skip to content

Disable NodeLease and RuntimeClass tests temporarily#22857

Merged
smarterclayton merged 1 commit intoopenshift:masterfrom
smarterclayton:disable_tests
May 18, 2019
Merged

Disable NodeLease and RuntimeClass tests temporarily#22857
smarterclayton merged 1 commit intoopenshift:masterfrom
smarterclayton:disable_tests

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented May 18, 2019

They are broken until a 1.14 kubelet lands

@smarterclayton
Disable NodeLease and RuntimeClass tests temporarily
11bec7f 
They are broken until a 1.14 kubelet lands
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2019
@wking
Copy link
Copy Markdown
Member

wking commented May 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton mentioned this pull request May 18, 2019
Closed
@smarterclayton smarterclayton merged commit e16e54b into openshift:master May 18, 2019
@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented May 18, 2019

Merging to unblock the queue, upgrade was a flake

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 18, 2019

@smarterclayton: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade 11bec7f link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danwinship danwinship mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smarterclayton @wking @openshift-ci-robot