Skip to content

Bug 1711569: reenable node lease tests#23198

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:fixes/reenable_node_lease_tests
Jun 19, 2019
Merged

Bug 1711569: reenable node lease tests#23198
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:fixes/reenable_node_lease_tests

Conversation

@rphillips
Copy link
Copy Markdown
Contributor

@rphillips rphillips commented Jun 18, 2019

Reenable node lease tests since we have a 1.14 kubelet now.

ref: https://bugzilla.redhat.com/show_bug.cgi?id=1711569

/cc @sjenning

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2019

@rphillips: This pull request references a valid Bugzilla bug.

Details

In response to this:

Bug 1711569: reenable node lease tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2019
@rphillips
Copy link
Copy Markdown
Contributor Author

rphillips commented Jun 18, 2019

/retest

@rphillips
Copy link
Copy Markdown
Contributor Author

rphillips commented Jun 18, 2019

prow/images passed but it looks like the webhook went into the ether.

@rphillips
Copy link
Copy Markdown
Contributor Author

rphillips commented Jun 18, 2019

/assign @smarterclayton

@rphillips rphillips force-pushed the fixes/reenable_node_lease_tests branch from 3ea27d3 to 4472597 Compare June 19, 2019 14:24
soltysh
soltysh approved these changes Jun 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@rphillips
Copy link
Copy Markdown
Contributor Author

rphillips commented Jun 19, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit b648b17 into openshift:master Jun 19, 2019
@rphillips rphillips mentioned this pull request Jun 20, 2019
Merged
@danwinship danwinship mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rphillips @openshift-ci-robot @openshift-bot @soltysh @smarterclayton @openshift-merge-robot