Skip to content

Revert "Bug 1711569: reenable node lease tests"#23227

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:revert-23198-fixes/reenable_node_lease_tests
Jun 20, 2019
Merged

Revert "Bug 1711569: reenable node lease tests"#23227
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
rphillips:revert-23198-fixes/reenable_node_lease_tests

Conversation

@rphillips
Copy link
Copy Markdown
Contributor

@rphillips rphillips commented Jun 20, 2019

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 20, 2019

@rphillips: This pull request references a valid Bugzilla bug.

Details

In response to this:

Revert "Bug 1711569: reenable node lease tests"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2019
@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Jun 20, 2019

/lgtm
/assign @smarterclayton
Need to follow up on how this got past CI in the first place 😞

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@sjenning
Copy link
Copy Markdown
Contributor

sjenning commented Jun 20, 2019

origin e2e seems to be fine with it
https://prow.svc.ci.openshift.org/?job=release-openshift-origin-installer-e2e-aws-4.2

however, OCP, not so much
https://prow.svc.ci.openshift.org/?job=release-openshift-ocp-installer-e2e-aws-4.2

not sure what difference could account for this result.

@openshift-merge-robot openshift-merge-robot merged commit 466ea13 into openshift:master Jun 20, 2019
@danwinship danwinship mentioned this pull request Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rphillips @openshift-ci-robot @sjenning @smarterclayton @openshift-merge-robot