Skip to content

Revert "test/extended/operators: ensure clusterversion current version is set"#24029

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:revert-1751820
Oct 28, 2019
Merged

Revert "test/extended/operators: ensure clusterversion current version is set"#24029
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sttts:revert-1751820

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Oct 25, 2019

The ClusterVersions config/v1 type has no status.desired.payload: https://github.com/openshift/api/blob/master/config/v1/types_cluster_version.go#L197

Pruning will remove this value. It blocks 1.16.2 rebase.

This reverts commit 2f21b74.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2019
@p0lyn0mial
Copy link
Copy Markdown
Contributor

@abhinavdahiya FYI

@p0lyn0mial
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 25, 2019

Unrelated flake.

/retest

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 25, 2019

/retest

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 25, 2019

Flakes.

/retest

@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 26, 2019

/retest

2 similar comments
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 27, 2019

/retest

@p0lyn0mial
Copy link
Copy Markdown
Contributor

/retest

@p0lyn0mial
Copy link
Copy Markdown
Contributor

/test e2e-gcp-upgrade

@p0lyn0mial
Copy link
Copy Markdown
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit f622c81 into openshift:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants