Skip to content

bumps to kubernetes 1.16.2#24014

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
p0lyn0mial:polynomial-rebase-1.16.2
Oct 29, 2019
Merged

bumps to kubernetes 1.16.2#24014
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
p0lyn0mial:polynomial-rebase-1.16.2

Conversation

@p0lyn0mial
Copy link
Copy Markdown
Contributor

@p0lyn0mial p0lyn0mial commented Oct 24, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 24, 2019
@p0lyn0mial p0lyn0mial mentioned this pull request Oct 24, 2019
Closed
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 24, 2019

/test e2e-aws

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 24, 2019

/assign @mfojtik @sttts

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 24, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2019
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 24, 2019

/retest

2 similar comments
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 24, 2019

/retest

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 25, 2019

/retest

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 25, 2019

It seems like ci/prow/e2e-aws job is failing because ClusterVersion has no current payload version. This check was brought back in #23992 and removed in 040f521

It reads status.desired.payload but I can't find the definition of that field for config.openshift.io/v1/ClusterVersion resource unless it reads a different resource?

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 25, 2019

It seems like ci/prow/e2e-aws job is failing because ClusterVersion has no current payload version. This check was brought back in #23992 and removed in 040f521

It reads status.desired.payload but I can't find the definition of that field for config.openshift.io/v1/ClusterVersion resource unless it reads a different resource?

fixed in #24029

@p0lyn0mial p0lyn0mial force-pushed the polynomial-rebase-1.16.2 branch from 28d2f38 to 25f22e8 Compare October 28, 2019 12:30
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 28, 2019

/test e2e-aws

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 28, 2019

/retest

@p0lyn0mial p0lyn0mial force-pushed the polynomial-rebase-1.16.2 branch from 25f22e8 to b37f3b0 Compare October 28, 2019 17:19
@p0lyn0mial p0lyn0mial force-pushed the polynomial-rebase-1.16.2 branch from b37f3b0 to 1c4b751 Compare October 28, 2019 18:05
@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 28, 2019

/retest

@p0lyn0mial
Copy link
Copy Markdown
Contributor Author

p0lyn0mial commented Oct 28, 2019

/test e2e-aws

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Oct 28, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2019
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Oct 28, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8d14e39 into openshift:master Oct 29, 2019
jsafrane added a commit to jsafrane/origin that referenced this pull request Nov 1, 2019
@jsafrane
UPSTREAM: Restore vendor/OWNERS
141f074 
The file was accidentally removed in openshift#24014.
@jsafrane jsafrane mentioned this pull request Nov 1, 2019
Merged
jsafrane added a commit to jsafrane/origin that referenced this pull request Nov 1, 2019
@jsafrane
UPSTREAM: Restore vendor/OWNERS
1084ddc 
The file was accidentally removed in openshift#24014.
jsafrane added a commit to jsafrane/origin that referenced this pull request Nov 1, 2019
@jsafrane
Add Ben as approver
4705d71 
He was in vendor/OWNERS that got accidentally removed in openshift#24014. Since it's
common to remove files in vendor/ during rebases, adding him to top-level
OWNERS is more stable.
@Miciah Miciah mentioned this pull request Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@timlnx timlnx Awaiting requested review from timlnx

Assignees

@mfojtik mfojtik

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@p0lyn0mial @sttts @openshift-ci-robot @openshift-bot @tnozicka @mfojtik @openshift-merge-robot