Skip to content

Add Ben as top-level OWNER#24070

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:restore-owners
Nov 5, 2019
Merged

Add Ben as top-level OWNER#24070
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jsafrane:restore-owners

Conversation

@jsafrane
Copy link
Copy Markdown
Contributor

@jsafrane jsafrane commented Nov 1, 2019 •
edited
Loading

He was in vendor/OWNERS that got accidentally removed in #24014. Since it's common to remove files in vendor/ during rebases, adding him to top-level OWNERS is more stable.

@jsafrane
Add Ben as approver
4705d71 
He was in vendor/OWNERS that got accidentally removed in openshift#24014. Since it's
common to remove files in vendor/ during rebases, adding him to top-level
OWNERS is more stable.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 1, 2019
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Nov 1, 2019

I removed @childsb :-(. Storage does not have a new teamlead yet.

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Nov 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2019
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Nov 1, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 1, 2019

New changes are detected. LGTM label has been removed.

@jsafrane jsafrane changed the title UPSTREAM: Restore vendor/OWNERS Add Ben as top-level OWNER Nov 1, 2019
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Nov 1, 2019

/approve

Storage team need to deliver fixes from upstream and deserve to have top-level approver.
This repository is not what it used to be before split, and they should not place OWNERS into vendor directory that is managed by glide and it will be by go.mod in future.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Nov 1, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Nov 1, 2019

@knobunc FYI, you're top level approver now. Enjoy our endless requests for approval :-)

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Nov 1, 2019

/retest

3 similar comments
@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Nov 4, 2019

/retest

@knobunc
Copy link
Copy Markdown
Contributor

knobunc commented Nov 4, 2019

/retest

@jsafrane
Copy link
Copy Markdown
Contributor Author

jsafrane commented Nov 5, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6fda113 into openshift:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@timlnx timlnx Awaiting requested review from timlnx

Assignees

@mfojtik mfojtik

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsafrane @mfojtik @openshift-ci-robot @knobunc @openshift-merge-robot