rebase 1.17.0 rc.2#24286
Conversation
openshift-ci-robot
added
the
size/XXL
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
from
1425aef to
8838cb5
Compare
openshift-ci-robot
added
the
needs-rebase
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
from
ca455e8 to
89fefb8
Compare
openshift-ci-robot
removed
the
needs-rebase
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
from
89fefb8 to
32deff9
Compare
|
/test e2e-aws |
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
4 times, most recently
from
c978880 to
acd2914
Compare
|
/retest |
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
2 times, most recently
from
d1031f3 to
8e9beff
Compare
|
/test e2e-gcp-builds |
|
/retest |
|
/test all |
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
from
8556bea to
98f6f7a
Compare
|
/test e2e-cmd |
|
requires #24305 |
p0lyn0mial
force-pushed
the
polynomial-rebase-1.17.0-rc.2
branch
from
98f6f7a to
d2b6dbd
Compare
|
requires #24304 |
| # etcd v3.3.17 carry until 4.4 | ||
| - package: github.com/coreos/etcd | ||
| version: v3.3.17 | ||
| version: v3.3.10 |
There was a problem hiding this comment.
this backleveling isn't correct. Get up with @hexfusion to find the right level, but at the very least don't backlevel it.
There was a problem hiding this comment.
this is exactly what upstream uses https://github.com/kubernetes/kubernetes/blob/v1.17.0-rc.2/go.mod#L231
also github.com/coreos/etcd was replaced by go.etcd.io/etcd
There was a problem hiding this comment.
I remember some issues in that area I can try to delete it.
There was a problem hiding this comment.
@hexfusion is away until 1/2 we need to make a decision.
There was a problem hiding this comment.
we decided to revert it back to v3.3.17
|
|
||
| upgCtx, err := getUpgradeContext(client, lifecycle.GetUpgradeTarget(), lifecycle.GetUpgradeImage()) | ||
| framework.ExpectNoError(err, "determining what to upgrade to version=%s image=%s", lifecycle.GetUpgradeTarget(), lifecycle.GetUpgradeImage()) | ||
| upgCtx, err := getUpgradeContext(client, gcp.GetUpgradeTarget(), gcp.GetUpgradeImage()) |
There was a problem hiding this comment.
I'm surprised this became cloud specific. You sure?
There was a problem hiding this comment.
| gvr("settings.k8s.io", "v1alpha1", "podpresets"), | ||
| gvr("storage.k8s.io", "v1alpha1", "volumeattachments"), | ||
| gvr("discovery.k8s.io", "v1alpha1", "endpointslices"), | ||
| gvr("extensions", "v1beta1", "deployments"), |
There was a problem hiding this comment.
these look wrong. Are we enabling endpoints that need to be shut off? Can we function with them shut off
There was a problem hiding this comment.
I think that
at runtime extensions/v1beta1 are disabled.
There was a problem hiding this comment.
without it, the test fails
fail [github.com/openshift/origin/test/extended/etcd/etcd_test_runner.go:72]: test failed:
etcd data does not match the types we saw:
in etcd data but not seen:
[
apps/v1beta1, Resource=controllerrevisions
extensions/v1beta1, Resource=podsecuritypolicies
extensions/v1beta1, Resource=replicasets
extensions/v1beta1, Resource=deployments
apps/v1beta1, Resource=deployments
apps/v1beta2, Resource=replicasets
apps/v1beta2, Resource=statefulsets
apps/v1beta2, Resource=deployments
extensions/v1beta1, Resource=networkpolicies
apps/v1beta2, Resource=daemonsets
apps/v1beta2, Resource=controllerrevisions
apps/v1beta1, Resource=statefulsets
extensions/v1beta1, Resource=daemonsets]
seen but not in etcd data:
[]
There was a problem hiding this comment.
|
/test e2e-azure-upgrade |
|
/test e2e-cmd |
seems like I forgot to add one, I don't know how the other tests can run without it. @smarterclayton could you run |
|
/test unit |
|
Here are the skew tests (1.17 control plane with 1.16 kubelets) https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24286/pull-ci-openshift-origin-master-e2e-gcp/4833 |
|
/test e2e-cmd |
|
The OOMFailure on build is https://bugzilla.redhat.com/show_bug.cgi?id=1785326 |
|
BZ opened for builds OOMKilled tests failing: https://bugzilla.redhat.com/show_bug.cgi?id=1785326 There is an RHCOS fix which was supposed to have landed already - if this either a) hasn't landed, or b) did land, but didn't fix this issue, I am OK with skipping the test. |
|
#24332 disables the build OOM test |
|
|
|
/retest |
|
conmon fix is in 44.81.201912191631.0, which is in 4.4 as of 3 hours ago. |
|
/hold cancel /override ci/prow/e2e-aws-disruptive see if we instamerge |
openshift-ci-robot
added
lgtm
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-aws-disruptive, ci/prow/e2e-gcp-builds DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, p0lyn0mial, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/e2e-gcp-builds |
|
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-gcp-builds DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@p0lyn0mial: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
12 participants
TODO in this PR
TODO after
extensions/v1beta(ingress)horizontalpodautoscalersandsecuritycontextconstraintsfrom the gc patch https://github.com/openshift/kubernetes/blob/origin-4.4-kubernetes-1.16.2/cmd/kube-controller-manager/app/patch_gc.go#L40This PR disables the following tests which were disabled before as part of
sig-cluster-lifecyclesuite, see kubernetes/kubernetes@0b3d50b#diff-3b1910d08fb8fd8b32956b5e264f87cb