Skip to content

add conditions to build api#24254

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:buildconditions
Jan 9, 2020
Merged

add conditions to build api#24254
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:buildconditions

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Dec 3, 2019 •
edited
Loading

implementation of https://jira.coreos.com/browse/DEVEXP-95

api updates: openshift/api#532
client-go updates(using temporary bump from bparees fork): openshift/client-go#128
openshift-apiserver updates(using temporary bump from bparees fork): openshift/openshift-apiserver#52
origin(e2e test, using temporary bump from bparees fork) updates: #24254

This won't pass until the openshift-apiserver PR is merged.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2019
This was referenced Dec 3, 2019
Merged
Closed
Merged
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Dec 3, 2019

/assign @adambkaplan

@bparees bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
bparees
bparees commented Dec 13, 2019
View reviewed changes
Comment thread glide.yaml Outdated
- package: github.com/openshift/apiserver-library-go
version: master
# temporary pin to avoid the kube 1.17 rebase
version: 7c5911e93780807f2082f34b259dfaf97a108222
Copy link
Copy Markdown
Contributor Author

@bparees bparees Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik @deads2k @sttts for now this hacks around the fact that origin is not compatible w/ master apiserver-library-go (until origin is rebased on kube 1.17).

This PR isn't really urgent, so if you'd rather just wait until origin is rebased that's fine, just let me know either way.

Copy link
Copy Markdown
Contributor Author

@bparees bparees Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like #24286 will resolve this, i'll wait for that.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Dec 13, 2019
@bparees bparees mentioned this pull request Dec 15, 2019
Merged
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 22, 2019
@bparees bparees changed the title [DO_NOT_MERGE] add conditions to build api add conditions to build api Jan 7, 2020
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Jan 7, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Jan 7, 2020

/retest

1 similar comment
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Jan 8, 2020

/retest

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Jan 8, 2020

@adambkaplan bump

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jan 9, 2020

@bparees why does this PR have vendor-update label? :)

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Jan 9, 2020

@bparees why does this PR have vendor-update label? :)

@mfojtik i think the original version of the PR included a temporary vendor bump which i've since removed, i guess the bot that added the label isn't smart enough to remove it? i'll remove the label manually.

@bparees bparees removed the vendor-update Touching vendor dir or related files label Jan 9, 2020
adambkaplan
adambkaplan approved these changes Jan 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Perhaps one day we'll agree on using .To(...) vs. .Should(...) (not today though).

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 9, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3d3f920 into openshift:master Jan 9, 2020
@bparees bparees deleted the buildconditions branch March 13, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@dmage dmage Awaiting requested review from dmage

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bparees @mfojtik @openshift-ci-robot @openshift-bot @adambkaplan @openshift-merge-robot