add conditions to build api by bparees · Pull Request #52 · openshift/openshift-apiserver

bparees · 2019-12-03T22:37:39Z

implementation of https://jira.coreos.com/browse/DEVEXP-95

api updates: openshift/api#532
client-go updates(using temporary bump from bparees fork): openshift/client-go#128
openshift-apiserver updates(using temporary bump from bparees fork): #52
origin(e2e test, using temporary bump from bparees fork) updates: openshift/origin#24254

bparees · 2019-12-03T22:40:10Z

/assign @adambkaplan

bparees · 2019-12-03T22:41:01Z

@adambkaplan Once this PR goes green, we can merge openshift/api#532 and openshift/client-go#128, then i'll come back and update this PR to use a proper bump. Then once it merges, we can retest/merge openshift/origin#24254

bparees · 2019-12-04T22:44:37Z

/retest

adambkaplan

@bparees minor nits on the timestamps, otherwise looks right

adambkaplan · 2019-12-09T19:34:19Z

+				Type:               buildv1.BuildConditionType(buildv1.BuildPhaseNew),
+				Status:             corev1.ConditionTrue,
+				LastUpdateTime:     metav1.Now(),
+				LastTransitionTime: metav1.Now(),


nit - use same object for LastUpdateTime and LastTransitionTime

adambkaplan · 2019-12-09T19:34:36Z

+				Type:               buildv1.BuildConditionType(buildv1.BuildPhaseNew),
+				Status:             corev1.ConditionTrue,
+				LastUpdateTime:     metav1.Now(),
+				LastTransitionTime: metav1.Now(),


nit - use same object for timestamps

adambkaplan · 2019-12-09T19:35:08Z

+			if c.Status != kapi.ConditionFalse {
+				build.Status.Conditions[i].Status = kapi.ConditionFalse
+				build.Status.Conditions[i].LastTransitionTime = metav1.Now()
+				build.Status.Conditions[i].LastUpdateTime = metav1.Now()


nit - use same object for timestamps

adambkaplan · 2019-12-09T19:35:23Z

+			Type:               buildapi.BuildConditionType(build.Status.Phase),
+			Status:             kapi.ConditionTrue,
+			LastUpdateTime:     metav1.Now(),
+			LastTransitionTime: metav1.Now(),


nit - use same object for timestamps

bparees · 2019-12-09T21:50:44Z

@adambkaplan updated. if you can lgtm openshift/api#532 i'll start the process of merging/bumping across the repos.

openshift-ci-robot · 2019-12-13T23:28:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/build/OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bparees · 2019-12-13T23:28:12Z

/hold cancel

@adambkaplan this is ready for re-review/merge.

bparees · 2019-12-16T13:27:32Z

/retest

bparees · 2019-12-18T18:34:47Z

/test cmd

bparees · 2019-12-18T22:59:46Z

/test cmd

bparees · 2019-12-20T20:41:11Z

/test cmd

bparees · 2020-01-06T18:05:50Z

/retest

@adambkaplan ptal

adambkaplan

/lgtm

openshift-ci-robot · 2020-01-07T18:57:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/build/OWNERS~~ [adambkaplan,bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2019

openshift-ci-robot requested review from coreydaley and gabemontero December 3, 2019 22:38

This was referenced Dec 3, 2019

add conditions to build api openshift/api#532

Merged

[DO_NOT_MERGE] add conditions to build api openshift/client-go#128

Closed

add conditions to build api openshift/origin#24254

Merged

openshift-ci-robot assigned adambkaplan Dec 3, 2019

bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019

adambkaplan suggested changes Dec 9, 2019

View reviewed changes

bparees force-pushed the buildconditions branch from 91e361c to cfe04bc Compare December 9, 2019 21:49

bparees force-pushed the buildconditions branch from cfe04bc to 5a778d0 Compare December 13, 2019 23:23

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2019

bparees force-pushed the buildconditions branch from 5a778d0 to bab2005 Compare December 13, 2019 23:24

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2019

bparees force-pushed the buildconditions branch from bab2005 to a3744ea Compare December 13, 2019 23:27

bparees changed the title ~~[DO_NOT_MERGE] add conditions to build api~~ add conditions to build api Dec 13, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2019

bparees added 2 commits December 18, 2019 09:30

add conditions to internal build api

fd4e22d

populate build conditions based on build phase

fb2fd36

bparees force-pushed the buildconditions branch from a3744ea to fb2fd36 Compare December 18, 2019 14:30

adambkaplan approved these changes Jan 7, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2020

openshift-merge-robot merged commit b6c37a5 into openshift:master Jan 7, 2020

Conversation

bparees commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented Dec 3, 2019

Uh oh!

bparees commented Dec 3, 2019

Uh oh!

bparees commented Dec 4, 2019

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

adambkaplan Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

adambkaplan Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

adambkaplan Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

adambkaplan Dec 9, 2019

Choose a reason for hiding this comment

Uh oh!

bparees commented Dec 9, 2019

Uh oh!

openshift-ci-robot commented Dec 13, 2019

Uh oh!

bparees commented Dec 13, 2019

Uh oh!

bparees commented Dec 16, 2019

Uh oh!

bparees commented Dec 18, 2019

Uh oh!

bparees commented Dec 18, 2019

Uh oh!

bparees commented Dec 20, 2019

Uh oh!

bparees commented Jan 6, 2020

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bparees commented Dec 3, 2019 •

edited

Loading