Skip to content

add conditions to build api#532

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:buildconditions
Dec 12, 2019
Merged

add conditions to build api#532
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
bparees:buildconditions

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Dec 3, 2019

implementation of https://jira.coreos.com/browse/DEVEXP-95

api updates: #532
client-go updates(using temporary bump from bparees fork): openshift/client-go#128
openshift-apiserver updates(using temporary bump from bparees fork): openshift/openshift-apiserver#52
origin(e2e test, using temporary bump from bparees fork) updates: openshift/origin#24254

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2019
@bparees bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Dec 3, 2019

/assign @adambkaplan

@bparees bparees changed the title [DO_NOT_MERGE] add conditions to build api add conditions to build api Dec 11, 2019
@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Dec 11, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e9cda59 into openshift:master Dec 12, 2019
@bparees bparees deleted the buildconditions branch October 26, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants