Skip to content

[DO_NOT_MERGE] add conditions to build api#128

Closed
bparees wants to merge 1 commit intoopenshift:masterfrom
bparees:buildconditions
Closed

[DO_NOT_MERGE] add conditions to build api#128
bparees wants to merge 1 commit intoopenshift:masterfrom
bparees:buildconditions

Conversation

@bparees
Copy link
Copy Markdown
Contributor

@bparees bparees commented Dec 3, 2019

implementation of https://jira.coreos.com/browse/DEVEXP-95

api updates: openshift/api#532
client-go updates(using temporary bump from bparees fork): #128
openshift-apiserver updates(using temporary bump from bparees fork): openshift/openshift-apiserver#52
origin(e2e test, using temporary bump from bparees fork) updates: openshift/origin#24254

@bparees bparees added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bparees
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Dec 3, 2019

/assign @adambkaplan

@openshift-ci-robot
Copy link
Copy Markdown

@bparees: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify ce032f3 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Copy Markdown
Contributor Author

bparees commented Dec 13, 2019

no client gen needed since only a new field was added.

@bparees bparees closed this Dec 13, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2019
@openshift-ci-robot
Copy link
Copy Markdown

@bparees: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants