Bug 1784334: Revert "check ServiceCatalog basic usages in OCP 4.x"#24315
Bug 1784334: Revert "check ServiceCatalog basic usages in OCP 4.x"#24315shawn-hurley wants to merge 1 commit intomasterfrom
Conversation
openshift-ci-robot
requested review from
jianzhangbjz,
jmrodri and
smarterclayton
openshift-ci-robot
added
size/XL
|
Disabling because: this will cause flakes in 4.3 and 4.4 tests we should move these to serial tests IIUC |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@shawn-hurley Glad to know it. Thanks! I guess Service Catalog throw alerts only for 4.4. I was wondering if we can cherry-pick these automation tests to 4.1, 4.2, 4.3. And, in the future, can we contribute Service Catalog automation test cases to the 4.1, 4.2, 4.3 directly? No more submit PRs to the master branch. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jianzhangbjz my understanding is you should be able to submit a PR directly to the 4.3, 4.2, & 4.1 branches directly. The tests in 4.4 should actually be looking for service catalog to be removed. The 4.3 service catalog operator does create a prometheusrule and alerts. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianzhangbjz, jmrodri, shawn-hurley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
@jmrodri Thanks! But, I was told the workflow should be we submit the PR to the master branch, and then, the bot can cherry-pick it to the old versions. @bparees Can I submit the PR to the old version branch directly? Thanks! |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@shawn-hurley: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-ci-robot
added
the
needs-rebase
|
@shawn-hurley: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Needs a rebase, @shawn-hurley |
|
/retitle Bug 1784837: Revert "check ServiceCatalog basic usages in OCP 4.x" |
openshift-ci-robot
changed the title
|
@shawn-hurley: This pull request references Bugzilla bug 1784837, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@wking: This pull request references Bugzilla bug 1784837, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/retitle Bug 1784334: Revert "check ServiceCatalog basic usages in OCP 4.x" |
openshift-ci-robot
changed the title
|
@shawn-hurley: This pull request references Bugzilla bug 1784334, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Please close this PR in favor of PR #24323 |
you can do it either way, but you must have merged to each prior branch before it can be merged to the next. So you need to merge into master before your PR against release-4.3 will be merged (you can open it, but it will not be merged). And then release-4.3 must merge before release-4.3, etc. Also before you can merge to release-4.3 you need a BZ against 4.4 that is in "modified". The patch manager+group leads will enforce those rules for release-4.3/release-4.2/release-4.1. |
|
@bparees Thanks! Must we create a bug for the automation PR? It's a little bit of unreasonable. Do we consider a new workflow for automation?
@shawn-hurley Service Catalog will throw alerts in 4.4 as we designed. However, these alerts lead to other tests to fail. Actually, in my opinion, the customers will encounter this scenario too. I think we should find out the root causes, not remove Service Catalog tests simply. Or am I missing something? |
we require bugs for any merge into a non-master branch. you can ask the patch-manager to override the requirement, but it's generally going to be faster to just create the bugs and follow the process than to argue for an exception. And this should not be a normal thing (needing to merge automation/tests into non-master branches). particularly once we put all the missing automation in place. |
|
@bparees Many thanks for your explanation! Yeah, I see. |
7 participants
Reverts #23352
/cc @smarterclayton @jianzhangbjz @jmrodri
this test is causing consistent CI flakes and we should remove it.