Skip to content

Bug 1786409: Merge pull request #23352 from jianzhangbjz/service-catalog#24349

Closed
jianzhangbjz wants to merge 1 commit intoopenshift:release-4.1from
jianzhangbjz:release-4.1
Closed

Bug 1786409: Merge pull request #23352 from jianzhangbjz/service-catalog#24349
jianzhangbjz wants to merge 1 commit intoopenshift:release-4.1from
jianzhangbjz:release-4.1

Conversation

@jianzhangbjz
Copy link
Copy Markdown
Contributor

@jianzhangbjz jianzhangbjz commented Dec 25, 2019

check ServiceCatalog basic usages in OCP 4.1.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 25, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz
To complete the pull request process, please assign knobunc
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianzhangbjz jianzhangbjz changed the title Merge pull request #23352 from jianzhangbjz/service-catalog Bug 1786409: Merge pull request #23352 from jianzhangbjz/service-catalog Dec 25, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 25, 2019
@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jan 6, 2020

/retest

@eparis
Copy link
Copy Markdown
Member

eparis commented Jan 7, 2020

What are we doing here? just updating some tests in 4.1? why?

@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from jianzhangbjz Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from jianzhangbjz Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from jianzhangbjz Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from jianzhangbjz Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from jianzhangbjz Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@openshift openshift deleted a comment from openshift-bot Jan 7, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 7, 2020
@eparis
Copy link
Copy Markdown
Member

eparis commented Jan 7, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 7, 2020

@eparis: This pull request references Bugzilla bug 1786409, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "---" instead
  • expected Bugzilla bug 1786409 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jan 8, 2020

@eparis In OCP 4.3 or 4.4, Service Catalog will throw alerts once it is installed. Other tests will fail on those alerts. So we remove these tests from the master branch(see #24323 #24315). But, we should test it in released 4.1.z, 4.2.z.

@cuppett
Copy link
Copy Markdown
Member

cuppett commented Jan 17, 2020

/retest

1 similar comment
@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Feb 18, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 4, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 4, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 5, 2020

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 5, 2020
@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jul 6, 2020

/remove-lifecycle rotten

@openshift-ci-robot openshift-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 6, 2020
@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jul 6, 2020

/test e2e-aws

1 similar comment
@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jul 10, 2020

/test e2e-aws

@jianzhangbjz
Copy link
Copy Markdown
Contributor Author

jianzhangbjz commented Jul 13, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 13, 2020

@jianzhangbjz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 364ddda link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 27, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 27, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 26, 2020

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 26, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Dec 26, 2020

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 26, 2020

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

No one assigned

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jianzhangbjz @openshift-ci-robot @eparis @cuppett @openshift-bot @openshift-merge-robot