Test timing of SA pull secret creation by adambkaplan · Pull Request #24776 · openshift/origin

adambkaplan · 2020-03-26T18:11:08Z

Ensure service account pull secrets are created in 2 seconds or less.

adambkaplan · 2020-03-26T18:11:45Z

+		sa, err := clusterAdminKubeClient.CoreV1().ServiceAccounts(sa.Namespace).Create(sa)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		g.By("waiting for service account's pull secret to be created")
+		_, _, err = waitForServiceAccountPullSecret(clusterAdminKubeClient, sa.Namespace, sa.Name, 5, time.Second)


@mfojtik @smarterclayton Is 5 seconds a reasonable maximum to fail on?

openshift-ci-robot · 2020-03-26T18:12:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-01T14:44:30Z

@adambkaplan: This pull request references Bugzilla bug 1765294, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1765294: Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-01T17:22:36Z

@adambkaplan: This pull request references Bugzilla bug 1785023, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1785023: Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2020-04-06T13:33:02Z

/retest

/assign @bparees
/cc @smarterclayton

bparees

minor nit.

also please run the tests on this PR 4-5 times before merging to confirm we're not introducing a flaky test (i don't know how reliable the 2s timing will be)

openshift-ci-robot · 2020-04-09T13:36:49Z

@adambkaplan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Test timing of SA pull secret creation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2020-04-09T14:33:06Z

@adambkaplan please squash and let me know when you've seen 4-5 passing runs and i'll lgtm.

adambkaplan · 2020-04-17T18:23:10Z

/retest

adambkaplan · 2020-04-20T12:43:05Z

/retest

hit by CI issues

danehans · 2020-04-20T19:05:41Z

@adambkaplan does this PR need to be linked to BZ 1819849?

* Ensure service account pull secrets are created in 2 seconds or less. * Dump secrets instead of ocm logs for pull secret controller e2e tests.

adambkaplan · 2020-04-21T17:30:26Z

/retest

adambkaplan · 2020-04-22T16:28:58Z

/retest

/test e2e-gcp

/test e2e-aws-fips

adambkaplan · 2020-04-24T13:12:32Z

/test e2e-gcp

/test e2e-aws-fips

adambkaplan · 2020-05-12T14:26:12Z

/retest

adambkaplan · 2020-06-09T11:37:20Z

/test e2e-aws

/test e2e-gcp

/test e2e-gcp-builds

adambkaplan · 2020-06-22T18:17:01Z

/test e2e-gcp

/test e2e-aws-fips

/test e2e-aws-serial

openshift-ci-robot · 2020-06-22T19:04:29Z

@adambkaplan: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	`11ec288`	link	`/test e2e-aws-fips`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-10-22T19:04:00Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot · 2020-10-23T04:04:41Z

@adambkaplan: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-cmd	`11ec288`	link	`/test e2e-agnostic-cmd`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adambkaplan · 2020-10-23T19:24:20Z

/close

No longer relevant

openshift-ci-robot · 2020-10-23T19:24:37Z

@adambkaplan: Closed this PR.

Details

In response to this:

/close

No longer relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2020

adambkaplan commented Mar 26, 2020

View reviewed changes

openshift-ci-robot requested review from ironcladlou and knobunc March 26, 2020 18:12

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020

adambkaplan force-pushed the test-sa-secret-creation branch from 91f9cc5 to fb06fd5 Compare April 1, 2020 14:43

adambkaplan changed the title ~~WIP - Test timing of service account pull secrets~~ Bug 1765294: Test timing of SA pull secret creation Apr 1, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 1, 2020

adambkaplan mentioned this pull request Apr 1, 2020

Bug 1785023: Increase pull secrets controller QPS to 100 openshift/openshift-controller-manager#84

Merged

adambkaplan force-pushed the test-sa-secret-creation branch from fb06fd5 to 4922f6b Compare April 1, 2020 17:06

adambkaplan changed the title ~~Bug 1765294: Test timing of SA pull secret creation~~ Bug 1785023: Test timing of SA pull secret creation Apr 1, 2020

adambkaplan force-pushed the test-sa-secret-creation branch from 4922f6b to 5b5d7b0 Compare April 2, 2020 14:49

openshift-ci-robot assigned bparees Apr 6, 2020

openshift-ci-robot requested a review from smarterclayton April 6, 2020 13:33

bparees requested changes Apr 6, 2020

View reviewed changes

Comment thread test/extended/controller_manager/pull_secret.go Outdated

adambkaplan changed the title ~~Bug 1785023: Test timing of SA pull secret creation~~ Test timing of SA pull secret creation Apr 9, 2020

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020

adambkaplan force-pushed the test-sa-secret-creation branch from b4fcc85 to a7481aa Compare April 9, 2020 14:56

adambkaplan force-pushed the test-sa-secret-creation branch from a7481aa to ffbed34 Compare April 17, 2020 17:38

adambkaplan force-pushed the test-sa-secret-creation branch from ffbed34 to 2733ba2 Compare April 20, 2020 17:56

Test timing of SA pull secret creation

11ec288

* Ensure service account pull secrets are created in 2 seconds or less. * Dump secrets instead of ocm logs for pull secret controller e2e tests.

adambkaplan force-pushed the test-sa-secret-creation branch from 2733ba2 to 11ec288 Compare April 21, 2020 01:01

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020

openshift-ci-robot closed this Oct 23, 2020

Conversation

adambkaplan commented Mar 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adambkaplan Mar 26, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 26, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

openshift-ci-robot commented Apr 1, 2020

Uh oh!

adambkaplan commented Apr 6, 2020

Uh oh!

bparees left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 9, 2020

Uh oh!

bparees commented Apr 9, 2020

Uh oh!

adambkaplan commented Apr 17, 2020

Uh oh!

adambkaplan commented Apr 20, 2020

Uh oh!

danehans commented Apr 20, 2020

Uh oh!

adambkaplan commented Apr 21, 2020

Uh oh!

adambkaplan commented Apr 22, 2020

Uh oh!

adambkaplan commented Apr 24, 2020

Uh oh!

adambkaplan commented May 12, 2020

Uh oh!

adambkaplan commented Jun 9, 2020

Uh oh!

adambkaplan commented Jun 22, 2020

Uh oh!

openshift-ci-robot commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Oct 22, 2020

Uh oh!

openshift-merge-robot commented Oct 23, 2020

Uh oh!

adambkaplan commented Oct 23, 2020

Uh oh!

openshift-ci-robot commented Oct 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adambkaplan commented Mar 26, 2020 •

edited

Loading

openshift-ci-robot commented Jun 22, 2020 •

edited

Loading