Skip to content

Test timing of SA pull secret creation #24776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adambkaplan wants to merge 1 commit into from
Closed

Test timing of SA pull secret creation #24776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions test/extended/controller_manager/pull_secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ var _ = g.Describe("[sig-devex][Feature:OpenShiftControllerManager]", func() {

g.AfterEach(func() {
if g.CurrentGinkgoTestDescription().Failed {
g.By("dumping openshift-controller-manager logs")
exutil.DumpPodLogsStartingWithInNamespace("controller-manager", "openshift-controller-manager", oc.AsAdmin())
g.By("dumping secrets")
exutil.DumpSecretStates(oc)
}
})

Expand Down Expand Up @@ -197,4 +197,20 @@ var _ = g.Describe("[sig-devex][Feature:OpenShiftControllerManager]", func() {
t.Fatalf("error waiting for pull secret deletion: %v", err)
}
})

g.It("checks service account pull secret creation timing", func() {
clusterAdminKubeClient := oc.AdminKubeClient()
saNamespace := oc.Namespace()

g.By("creating test service account")
sa := &corev1.ServiceAccount{
ObjectMeta: metav1.ObjectMeta{Name: "new-sa", Namespace: saNamespace},
}

sa, err := clusterAdminKubeClient.CoreV1().ServiceAccounts(sa.Namespace).Create(context.Background(), sa, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())
g.By("waiting up to 2 seconds for the service account's pull secret to be created")
_, _, err = waitForServiceAccountPullSecret(clusterAdminKubeClient, sa.Namespace, sa.Name, 20, 100*time.Millisecond)
o.Expect(err).NotTo(o.HaveOccurred())
})
})
1 change: 1 addition & 0 deletions test/extended/util/annotate/generated/zz_generated.annotations.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions test/extended/util/framework.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,17 @@ func DumpConfigMapStates(oc *CLI) {
e2e.Logf(out)
}

// DumpSecretStates dumps the state of all Secrets in the CLI's current namespace
func DumpSecretStates(oc *CLI) {
e2e.Logf("Dumping secret states for namespace %s", oc.Namespace())
out, err := oc.AsAdmin().Run("get").Args("secrets", "-o", "yaml").Output()
if err != nil {
e2e.Logf("Error dumping secret states: %v", err)
return
}
e2e.Logf(out)
}

// GetMasterThreadDump will get a golang thread stack dump
func GetMasterThreadDump(oc *CLI) {
out, err := oc.AsAdmin().Run("get").Args("--raw", "/debug/pprof/goroutine?debug=2").Output()
Expand Down