Bug 1845188: Revert "UPSTREAM: <carry>: Disable by default the addition of service ca to token secrets by marun · Pull Request #25078 · openshift/origin

marun · 2020-06-08T16:55:18Z

This reverts commit f24fbff.

openshift-ci-robot · 2020-06-08T16:55:19Z

@marun: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Revert "UPSTREAM: : Disable by default the addition of service ca to token secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…ddition of service ca to token secrets" This reverts commit f24fbff.

mfojtik · 2020-06-09T07:41:08Z

/retest

mfojtik · 2020-06-09T07:41:31Z

/lgtm

openshift-ci-robot · 2020-06-09T07:41:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-06-09T08:00:49Z

@marun: This pull request references Bugzilla bug 1845188, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "---" instead
expected Bugzilla bug 1845188 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1845188: Revert "UPSTREAM: : Disable by default the addition of service ca to token secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-09T08:01:22Z

overriding valid-bug as there is no intent to revert this in master branch

openshift-bot · 2020-06-09T08:23:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T08:36:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2020-06-09T08:44:33Z

/bugzilla refresh

openshift-ci-robot · 2020-06-09T08:44:36Z

@mfojtik: This pull request references Bugzilla bug 1845188, which is invalid:

expected Bugzilla bug 1845188 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-09T09:15:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T09:28:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T11:38:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T12:30:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T13:11:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-09T13:22:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2020-06-09T13:37:21Z

/override ci/prow/e2e-aws-disruptive

This is known failure and should not be blocking

openshift-ci-robot · 2020-06-09T13:37:54Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-disruptive

Details

In response to this:

/override ci/prow/e2e-aws-disruptive

This is known failure and should not be blocking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-09T13:39:48Z

/override ci/prow/e2e-vsphere

this test is flaking on unrelated networking/router failures

openshift-ci-robot · 2020-06-09T13:43:12Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-vsphere

Details

In response to this:

/override ci/prow/e2e-vsphere

this test is flaking on unrelated networking/router failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-09T13:43:37Z

/override ci/prow/e2e-conformance-k8s

this passed last time on 2020-04-29: https://bugzilla.redhat.com/show_bug.cgi?id=1845549

openshift-ci-robot · 2020-06-09T13:43:58Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-conformance-k8s

Details

In response to this:

/override ci/prow/e2e-conformance-k8s

this passed last time on 2020-04-29, the TRT team will investigate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-09T13:45:10Z

@marun: All pull requests linked via external trackers have merged: . Bugzilla bug 1845188 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1845188: Revert "UPSTREAM: : Disable by default the addition of service ca to token secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

runcom · 2020-06-10T15:09:09Z

@mfojtik release-4.6 aka master is affected by this - can we revert on master as well? (MCO e2e-aws is busted)

mfojtik · 2020-06-10T15:10:01Z

@mfojtik release-4.6 aka master is affected by this - can we revert on master as well? (MCO e2e-aws is busted)

no, you have to fix MCO :)

runcom · 2020-06-10T15:17:49Z

@mfojtik release-4.6 aka master is affected by this - can we revert on master as well? (MCO e2e-aws is busted)

no, you have to fix MCO :)

actually, we're still looking at the failures and it doesn't even seem to be this - sorry for the noise (something related to the fedora registry 🤷‍♂️

mfojtik · 2020-06-10T15:19:15Z

@mfojtik release-4.6 aka master is affected by this - can we revert on master as well? (MCO e2e-aws is busted)

no, you have to fix MCO :)

actually, we're still looking at the failures and it doesn't even seem to be this - sorry for the noise (something related to the fedora registry 🤷‍♂️

#25087 this? :)

runcom · 2020-06-10T15:32:57Z

#25087 this? :)

exactly 😂

openshift-ci-robot requested a review from mfojtik June 8, 2020 16:55

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 8, 2020

UPSTREAM: <drop>: Revert "UPSTREAM: <carry>: Disable by default the a…

e2e9c6e

…ddition of service ca to token secrets" This reverts commit f24fbff.

mfojtik added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 9, 2020

openshift-ci-robot assigned mfojtik Jun 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020

mfojtik added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 9, 2020

mfojtik changed the title ~~Revert "UPSTREAM: <carry>: Disable by default the addition of service ca to token secrets~~ Bug 1845188: Revert "UPSTREAM: <carry>: Disable by default the addition of service ca to token secrets Jun 9, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 9, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2020

mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 9, 2020

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 9, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2020

mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 9, 2020

openshift-merge-robot merged commit cc5c3e3 into openshift:release-4.5 Jun 9, 2020

Conversation

marun commented Jun 8, 2020

Uh oh!

openshift-ci-robot commented Jun 8, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

openshift-bot commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

mfojtik commented Jun 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

openshift-ci-robot commented Jun 9, 2020

Uh oh!

runcom commented Jun 10, 2020

Uh oh!

mfojtik commented Jun 10, 2020

Uh oh!

runcom commented Jun 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfojtik commented Jun 10, 2020

Uh oh!

runcom commented Jun 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mfojtik commented Jun 9, 2020 •

edited

Loading

runcom commented Jun 10, 2020 •

edited

Loading