Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64#25087
Conversation
…/fedora:32-x86_64 This test was failing because of registry.fedoraproject.org being down. We want to consistently rely on quay for any adhoc image we need to run.
|
@enxebre: This pull request references Bugzilla bug 1845792, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@enxebre: This pull request references Bugzilla bug 1845792, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.5 |
|
@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
|
/test e2e-gcp |
|
👍 |
| // (-> we need to create a pod to try to reach it) and contains the token | ||
| // of the node-bootstrapper SA, so no random pods should be able to see it | ||
| pod, err := exutil.NewPodExecutor(oc, "get-bootstrap-creds", "registry.fedoraproject.org/fedora:30") | ||
| pod, err := exutil.NewPodExecutor(oc, "get-bootstrap-creds", "quay.io/fedora/fedora:32-x86_64") |
There was a problem hiding this comment.
Let's not hardcode the architecture...really unfortunate quay.io still doesn't support manifest lists.
Why is this test using Fedora at all versus one of the OpenShift images?
There was a problem hiding this comment.
...really unfortunate quay.io still doesn't support manifest lists...
Quay v3 does support manifest lists (or at least something in this space).
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25087. Bugzilla bug 1845792 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@enxebre: new pull request created: #25093 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@runcom: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/origin\n ! [rejected] cherry-pick-25087-to-release-4.5 -> cherry-pick-25087-to-release-4.5 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/origin'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@miabbott: new pull request created: #25393 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@miabbott: new pull request created: #25394 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This test was failing because of registry.fedoraproject.org being down. We want to consistently rely on quay for any adhoc image we need to run.