Skip to content

Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64#25087

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
enxebre:bz-1845792
Jun 10, 2020
Merged

Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64#25087
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
enxebre:bz-1845792

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Jun 10, 2020

This test was failing because of registry.fedoraproject.org being down. We want to consistently rely on quay for any adhoc image we need to run.

…/fedora:32-x86_64

This test was failing because of registry.fedoraproject.org being down. We want to consistently rely on quay for any adhoc image we need to run.
@enxebre enxebre changed the title Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64 Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64 Jun 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 10, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: This pull request references Bugzilla bug 1845792, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: This pull request references Bugzilla bug 1845792, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jun 10, 2020

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 10, 2020
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Jun 10, 2020

/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link
Copy Markdown

@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Jun 10, 2020

/test unit

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Jun 10, 2020

/test e2e-gcp

@runcom
Copy link
Copy Markdown
Member

runcom commented Jun 10, 2020

👍

// (-> we need to create a pod to try to reach it) and contains the token
// of the node-bootstrapper SA, so no random pods should be able to see it
pod, err := exutil.NewPodExecutor(oc, "get-bootstrap-creds", "registry.fedoraproject.org/fedora:30")
pod, err := exutil.NewPodExecutor(oc, "get-bootstrap-creds", "quay.io/fedora/fedora:32-x86_64")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not hardcode the architecture...really unfortunate quay.io still doesn't support manifest lists.

Why is this test using Fedora at all versus one of the OpenShift images?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...really unfortunate quay.io still doesn't support manifest lists...

Quay v3 does support manifest lists (or at least something in this space).

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5d61ad4 into openshift:master Jun 10, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25087. Bugzilla bug 1845792 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1845792: Drop registry.fedoraproject.org/fedora:30 in favour of quay.io/fedora:32-x86_64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@enxebre: new pull request created: #25093

Details

In response to this:

/cherry-pick release-4.5
/cherry-pick release-4.4
/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Copy Markdown
Member

runcom commented Jun 19, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@runcom: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/origin\n ! [rejected] cherry-pick-25087-to-release-4.5 -> cherry-pick-25087-to-release-4.5 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/origin'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Aug 9, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

@miabbott: new pull request created: #25393

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Copy Markdown
Member

miabbott commented Aug 9, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot
Copy link
Copy Markdown

@miabbott: new pull request created: #25394

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants