Skip to content

Bug 1848622: [release-4.3]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV#25138

Merged
bparees merged 1 commit intoopenshift:release-4.3from
enxebre:release-4.3-bug-1847185
Jun 19, 2020
Merged

Bug 1848622: [release-4.3]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV#25138
bparees merged 1 commit intoopenshift:release-4.3from
enxebre:release-4.3-bug-1847185

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Jun 17, 2020

manual cherry-pick for #25121 to get a 4.3 payload to test against ARO.
/hold

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 17, 2020

@enxebre: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@mjudeikis
Copy link
Copy Markdown
Contributor

mjudeikis commented Jun 17, 2020

/retest

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 18, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 18, 2020 •
edited
Loading

/retitle Bug 1847368: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 18, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 18, 2020 •
edited
Loading

/bugzilla refresh

@enxebre enxebre changed the title UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV Bug 1848622: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2020

@enxebre: This pull request references Bugzilla bug 1848622, which is invalid:

  • expected dependent Bugzilla bug 1847185 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1847368 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1847419 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1847185 to target a release in 4.4.0, 4.4.z, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1847368 to target a release in 4.4.0, 4.4.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1848622: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Jun 18, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 18, 2020

@enxebre: This pull request references Bugzilla bug 1848622, which is invalid:

  • expected dependent Bugzilla bug 1847185 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead
  • expected dependent Bugzilla bug 1847368 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1847419 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead
  • expected dependent Bugzilla bug 1847185 to target a release in 4.4.0, 4.4.z, but it targets "4.6.0" instead
  • expected dependent Bugzilla bug 1847368 to target a release in 4.4.0, 4.4.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre enxebre changed the title Bug 1848622: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV Bug 1848622: [release-4.3]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV Jun 18, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 19, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@openshift-bot: This pull request references Bugzilla bug 1848622, which is invalid:

  • expected dependent Bugzilla bug 1847419 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2020
@mfojtik mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 19, 2020
@bparees bparees merged commit d6d3cff into openshift:release-4.3 Jun 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25138. Bugzilla bug 1848622 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1848622: [release-4.3]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 19, 2020

@enxebre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit c0d583e link /test unit
ci/prow/e2e-gcp-upgrade c0d583e link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@enxebre @openshift-ci-robot @mjudeikis @sttts @openshift-bot @mfojtik @bparees @andyzhangx