Bug 1847185: fix: GetLabelsForVolume panic issue for azure disk PV

[enxebre]

This prevents GetAzureDiskLabels from panicking when c.DisksClient is nil.
This panicking makes the API server to crash loop for some ARO clusters as elaborated in https://bugzilla.redhat.com/show_bug.cgi?id=1847185

kubernetes/kubernetes#92166
kubernetes/kubernetes#92167

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1847185, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1847185: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/hold

[enxebre]

/bugzilla refresh

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1847185, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@enxebre: This pull request references Bugzilla bug 1847185, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1847185: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/retest

[enxebre]

/cherry-pick release-4.5

[openshift-cherrypick-robot]

@enxebre: once the present PR merges, I will cherry-pick it on top of release-4.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

/retest

[enxebre]

/hold cancel

[enxebre]

cc @sttts @mfojtik @jim-minter PTAL

[jim-minter]

@enxebre I'm encouraging upstream to fix this more comprehensively if it's possible. Might be worth waiting a little to see what happens?

[enxebre]

/hold
as per #25121 (comment)

[enxebre]

/hold cancel
Added latest upstream changes. I'd be happy to get this as it is to fix panicking and prevent any other cluster from getting to a crash looping state and so we can get it into 4.5 before freezing and backport to 4.4 asap.

Then if ARO still needs a way to instantiate the azure client for the api server can be discussed separately. I think getting back to https://github.com/Azure/ARO-RP/pull/487/files#diff-f23154e33f71b30de1fae50fbf2b1dadL56-L60 might be an option. FWIW cloud providers are planned to go out of tree in kubernetes 1.21 / OCP 4.8.

[enxebre]

/retest

[enxebre]

/retest

[jim-minter]

Added latest upstream changes. I'd be happy to get this as it is to fix panicking and prevent any other cluster from getting to a crash looping state and so we can get it into 4.5 before freezing and backport to 4.4 asap.

@enxebre I agree. We'd like to get this into 4.3 urgently.

[enxebre]

@jim-minter as per @mjudeikis this has been validated to prevent ARO from panicking.
@sttts @mfojtik can we get labels here?

[mfojtik]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[sttts]

/retest

[mfojtik]

merging with button, the queue is hosed and this is critical fix needed in ARO 4.5.

[openshift-ci-robot]

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25121. Bugzilla bug 1847185 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1847185: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@enxebre: new pull request created: #25168

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mfojtik]

@eparis @jwforres @stevekuznetsov 3 days of retesting this simple fix that is actually causing 40% of our ARO cluster to be broken... i would like to know how we can mitigate this in future.

[openshift-ci-robot]

@enxebre: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-serial	4691565	link	/test e2e-aws-serial
ci/prow/e2e-aws-fips	4691565	link	/test e2e-aws-fips
ci/prow/e2e-cmd	4691565	link	/test e2e-cmd
ci/prow/e2e-gcp	4691565	link	/test e2e-gcp
ci/prow/e2e-gcp-upgrade	4691565	link	/test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.