Skip to content

Bug 1847419: [release-4.4] UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV#25159

Merged
bparees merged 1 commit intoopenshift:release-4.4from
enxebre:release-4.4-bug-1847185
Jun 19, 2020
Merged

Bug 1847419: [release-4.4] UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV#25159
bparees merged 1 commit intoopenshift:release-4.4from
enxebre:release-4.4-bug-1847185

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Jun 18, 2020

manual cherry-pick for #25121.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: This pull request references Bugzilla bug 1847419, which is invalid:

  • expected dependent Bugzilla bug 1847368 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1847419: [release-4.4] UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 18, 2020
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Jun 18, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown

@openshift-bot: This pull request references Bugzilla bug 1847419, which is invalid:

  • expected dependent Bugzilla bug 1847368 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jun 19, 2020

@eparis @bparees permission to button merge this? i know this is bypassing our process, but 40% of ARO clusters are affected by this and we need to release this fix ASAP.

@mfojtik mfojtik added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 19, 2020
@mfojtik
Copy link
Copy Markdown
Contributor

mfojtik commented Jun 19, 2020

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-gcp

both flaking on node client cert requests armoring: [Top Level] node client cert requests armoring: deny pod's access to /config/master API endpoint [Suite:openshift/conformance/parallel] which is unrelated to this change and Node team was notified.

/override ci/prow/images

flakin on fedora mirrors timeout, DPTP team notified.

@openshift-ci-robot
Copy link
Copy Markdown

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-fips, ci/prow/e2e-gcp, ci/prow/images

Details

In response to this:

/override ci/prow/e2e-aws-fips
/override ci/prow/e2e-gcp

both flaking on node client cert requests armoring: [Top Level] node client cert requests armoring: deny pod's access to /config/master API endpoint [Suite:openshift/conformance/parallel] which is unrelated to this change and Node team was notified.

/override ci/prow/images

flakin on fedora mirrors timeout, DPTP team notified.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 19, 2020
@mfojtik mfojtik added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 19, 2020
@bparees bparees merged commit 9d33dd3 into openshift:release-4.4 Jun 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25159. Bugzilla bug 1847419 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1847419: [release-4.4] UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

@enxebre: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 4dc4988 link /test e2e-cmd
ci/prow/e2e-gcp 4dc4988 link /test e2e-gcp
ci/prow/e2e-aws-serial 4dc4988 link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants