Bug 1847368: [release-4.5]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV by enxebre · Pull Request #25158 · openshift/origin

enxebre · 2020-06-18T16:10:21Z

manual cherry-pick for #25121.

openshift-ci-robot · 2020-06-18T16:10:25Z

@enxebre: This pull request references Bugzilla bug 1847368, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead
expected dependent Bugzilla bug 1847185 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1847368: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-18T16:11:06Z

@enxebre: This pull request references Bugzilla bug 1847368, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.5.z" instead
expected dependent Bugzilla bug 1847185 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1847368: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2020-06-18T16:15:47Z

/bugzilla refresh

openshift-ci-robot · 2020-06-18T16:15:49Z

@enxebre: This pull request references Bugzilla bug 1847368, which is invalid:

expected dependent Bugzilla bug 1847185 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2020-06-18T16:27:28Z

/lgtm
/approve

openshift-ci-robot · 2020-06-18T16:27:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-06-18T19:48:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T01:00:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-06-19T01:00:34Z

@openshift-bot: This pull request references Bugzilla bug 1847368, which is invalid:

expected dependent Bugzilla bug 1847185 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-19T06:40:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T06:52:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T07:05:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T07:18:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T07:47:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T07:57:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T08:23:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-19T09:15:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

mfojtik · 2020-06-19T10:34:38Z

/bugzilla refresh

mfojtik · 2020-06-19T10:34:43Z

/retest

openshift-ci-robot · 2020-06-19T10:34:48Z

@mfojtik: This pull request references Bugzilla bug 1847368, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1847185 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1847185 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-19T11:15:59Z

/override ci/prow/e2e-vsphere
/override ci/prow/launch-vsphere

vsphere tests are totally unrelated to this change

openshift-ci-robot · 2020-06-19T11:16:37Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-vsphere, ci/prow/launch-vsphere

Details

In response to this:

/override ci/prow/e2e-vsphere
/override ci/prow/launch-vsphere

vsphere tests are totally unrelated to this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-06-19T11:38:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sttts · 2020-06-19T11:53:03Z

/retest

mfojtik · 2020-06-19T12:25:33Z

/retest

openshift-bot · 2020-06-19T12:43:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

enxebre · 2020-06-19T13:32:41Z

/test e2e-azure

enxebre · 2020-06-19T13:33:13Z

/test e2e-conformance-k8s

mfojtik · 2020-06-19T13:35:53Z

/retest

mfojtik · 2020-06-19T15:09:27Z

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-disruptive

mfojtik · 2020-06-19T15:10:07Z

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-azure
/override ci/prow/e2e-conformance-k8s
/override ci/prow/e2e-gcp-builds

mfojtik · 2020-06-19T15:10:58Z

button merging as fedoraproject is down, the CI is in flaky state and this is required for ARO.

mfojtik · 2020-06-19T15:11:04Z

/refresh

openshift-ci-robot · 2020-06-19T15:12:56Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws, ci/prow/e2e-aws-disruptive

Details

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-disruptive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-19T15:13:09Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-jenkins, ci/prow/e2e-azure, ci/prow/e2e-conformance-k8s, ci/prow/e2e-gcp-builds

Details

In response to this:

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-azure
/override ci/prow/e2e-conformance-k8s
/override ci/prow/e2e-gcp-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-19T15:13:38Z

/override ci/prow/e2e-vsphere
/override ci/prow/e2e-vsphere

openshift-ci-robot · 2020-06-19T15:14:00Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-vsphere

Details

In response to this:

/override ci/prow/e2e-vsphere
/override ci/prow/e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-06-19T15:14:15Z

/override ci/prow/launch-vsphere

openshift-ci-robot · 2020-06-19T15:14:37Z

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/launch-vsphere

Details

In response to this:

/override ci/prow/launch-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-06-19T15:14:49Z

@enxebre: All pull requests linked via external trackers have merged: openshift/origin#25158, kubernetes/kubernetes#92166. Bugzilla bug 1847368 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1847368: [release-4.5]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV

68527c4

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 18, 2020

openshift-ci-robot requested review from sjenning and timlnx June 18, 2020 16:10

openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 18, 2020

enxebre changed the title ~~Bug 1847368: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV~~ Bug 1847368: [release-4.5]: UPSTREAM: 92166: fix: GetLabelsForVolume panic issue for azure disk PV Jun 18, 2020

openshift-ci-robot assigned sttts Jun 18, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2020

mfojtik added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 19, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 19, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 19, 2020

mfojtik added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 19, 2020

enxebre mentioned this pull request Jun 19, 2020

[release-4.5] Bug 1847368: fix: GetLabelsForVolume panic issue for azure disk PV #25168

Closed

mfojtik merged commit 36962c8 into openshift:release-4.5 Jun 19, 2020

Conversation

enxebre commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

enxebre commented Jun 18, 2020

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

sttts commented Jun 18, 2020

Uh oh!

openshift-ci-robot commented Jun 18, 2020

Uh oh!

openshift-bot commented Jun 18, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

sttts commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

openshift-bot commented Jun 19, 2020

Uh oh!

enxebre commented Jun 19, 2020

Uh oh!

enxebre commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

openshift-ci-robot commented Jun 19, 2020

Uh oh!

mfojtik commented Jun 19, 2020

Uh oh!

enxebre commented Jun 18, 2020 •

edited

Loading