-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 1828858: use ExternalTrafficPolicy local for zero downtime #25482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Antonio Ojea <aojea@redhat.com>
|
@aojea: This pull request references Bugzilla bug 1828858, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@bparees can you please advice on the backport process? |
|
@aojea: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@aojea you don't need to backport to 4.6, 4.6 is fast-forwarded from master right now. so you can close this PR. and if you want to backport to 4.5, you can use "/cherry-pick release-4.5" on your master PR to automatically create a cherry pick backport (unless manual picking is required due to conficts/changes needed). |
|
/close |
|
@aojea: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry-pick from #25406
Use ExternalTrafficPolicy set to Local for the service used in the test
[sig-network-edge] Application behind service load balancer with PDB is not disrupted
This avoid that we do a double hop inside the cluster to reach the pod, since the traffic goes directly from the load balancer to the node that has the pod running.
Signed-off-by: Antonio Ojea aojea@redhat.com