Skip to content

Conversation

@aojea
Copy link

@aojea aojea commented Sep 7, 2020

cherry-pick from #25406

Use ExternalTrafficPolicy set to Local for the service used in the test
[sig-network-edge] Application behind service load balancer with PDB is not disrupted
This avoid that we do a double hop inside the cluster to reach the pod, since the traffic goes directly from the load balancer to the node that has the pod running.

Signed-off-by: Antonio Ojea aojea@redhat.com

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 7, 2020
@openshift-ci-robot
Copy link

@aojea: This pull request references Bugzilla bug 1828858, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1828858 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1828858: use ExternalTrafficPolicy local for zero downtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 7, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aojea
To complete the pull request process, please assign deads2k
You can assign the PR to them by writing /assign @deads2k in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Author

aojea commented Sep 14, 2020

/retest

3 similar comments
@sgreene570
Copy link
Contributor

/retest

@aojea
Copy link
Author

aojea commented Sep 15, 2020

/retest

@aojea
Copy link
Author

aojea commented Sep 17, 2020

/retest

@aojea
Copy link
Author

aojea commented Sep 17, 2020

@bparees can you please advice on the backport process?
is this the wrong branch or did I something wrong?

@openshift-ci-robot
Copy link

@aojea: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 7e74653 link /test e2e-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Sep 17, 2020

@aojea you don't need to backport to 4.6, 4.6 is fast-forwarded from master right now.

so you can close this PR.

and if you want to backport to 4.5, you can use "/cherry-pick release-4.5" on your master PR to automatically create a cherry pick backport (unless manual picking is required due to conficts/changes needed).

@aojea
Copy link
Author

aojea commented Sep 17, 2020

/close

@openshift-ci-robot
Copy link

@aojea: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants