Skip to content

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local #25406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 1, 2020
Merged

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local #25406

openshift-merge-robot merged 2 commits into from
Sep 1, 2020

Conversation

@aojea
Copy link

@aojea aojea commented Aug 11, 2020 •
edited
Loading

Use ExternalTrafficPolicy set to Local for the service used in the test
[sig-network-edge] Application behind service load balancer with PDB is not disrupted
This avoid that we do a double hop inside the cluster to reach the pod, since the traffic goes directly from the load balancer to the node that has the pod running.

@aojea
Copy link
Author

aojea commented Aug 11, 2020

/test e2e-aws-upgrade

@aojea
Copy link
Author

aojea commented Aug 11, 2020

/test e2e-aws-upgrade
/test e2e-gcp-upgrade

@aojea aojea changed the title use LoadBalancers with ExternalTrafficPolicy set to Local Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local Aug 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 11, 2020

@aojea: This pull request references Bugzilla bug 1828858, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea aojea mentioned this pull request Aug 11, 2020
Closed
@aojea
Copy link
Author

aojea commented Aug 11, 2020 •
edited
Loading

heh

ci/prow/e2e-gcp-upgrade — Job succeeded.

and passed in aws
/assign @deads2k
will retest again but the test worked 2/2 in aws and gcp
/test e2e-aws-upgrade
/test e2e-gcp-upgrade

@aojea
Copy link
Author

aojea commented Aug 11, 2020

this time it failed as always in GCP

Aug 11 21:47:43.712: Service was unreachable during disruption for at least 42s of 31m0s (2%):
Passed AWS
ci/prow/e2e-aws-upgrade — Job succeeded

/test e2e-aws-upgrade
/test e2e-gcp-upgrade

frobware and others added 2 commits August 12, 2020 10:18
@frobware
Bug 1861944: re-enable service upgrade
54e4908 
This was disabled in:

  openshift#25314
use ExternalTrafficPolicy local for zero downtime
908f332 
Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea
Copy link
Author

aojea commented Aug 12, 2020

it' even worse now in GCP

Aug 12 09:36:25.411: Service was unreachable during disruption for at least 1m28s of 30m5s (5%):

/test e2e-aws-upgrade
/test e2e-gcp-upgrade

@aojea
Copy link
Author

aojea commented Aug 12, 2020 •
edited
Loading

it failed again in GCP , passed in AWS

Aug 12 11:20:06.927: Service was unreachable during disruption for at least 41s of 31m50s (2%):

so, it seems we got lucky in the first try

however, the number of connections errors is lower, but the disruption time is higher, that can be due to the LB health-check interval

Aug 12 11:09:08.639 E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service stopped responding to GET requests over new connections
Aug 12 11:09:09.639 - 19s   E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service is not responding to GET requests over new connections
Aug 12 11:09:28.677 I ns/e2e-k8s-service-lb-available-3471 svc/service-test Service started responding to GET requests over new connections
Aug 12 11:13:54.639 E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service stopped responding to GET requests over new connections
Aug 12 11:13:54.666 I ns/e2e-k8s-service-lb-available-3471 svc/service-test Service started responding to GET requests over new connections
Aug 12 11:14:05.639 E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service stopped responding to GET requests over new connections
Aug 12 11:14:06.639 - 8s    E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service is not responding to GET requests over new connections
Aug 12 11:14:15.667 I ns/e2e-k8s-service-lb-available-3471 svc/service-test Service started responding to GET requests over new connections
Aug 12 11:16:53.639 E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service stopped responding to GET requests over new connections
Aug 12 11:16:54.639 - 8s    E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service is not responding to GET requests over new connections
Aug 12 11:17:03.667 I ns/e2e-k8s-service-lb-available-3471 svc/service-test Service started responding to GET requests over new connections
Aug 12 11:17:14.639 E ns/e2e-k8s-service-lb-available-3471 svc/service-test Service stopped responding to GET requests over new connections
Aug 12 11:17:14.669 I ns/e2e-k8s-service-lb-available-3471 svc/service-test Service started responding to GET requests over new connections

just curious @smarterclayton , any special reason to set ExternalTrafficPolicy to Cluster instead of Local for this test?

@marun
Copy link
Contributor

marun commented Aug 19, 2020

/retest

@aojea
Copy link
Author

aojea commented Aug 19, 2020

heh, it went through this time 👏

@marun
Copy link
Contributor

marun commented Aug 19, 2020

/lgtm

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2020

@aojea: This pull request references Bugzilla bug 1828858, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 19, 2020

@aojea: This pull request references Bugzilla bug 1828858, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Author

aojea commented Aug 20, 2020

/retest

1 similar comment
@aojea
Copy link
Author

aojea commented Aug 20, 2020

/retest

@aojea
Copy link
Author

aojea commented Aug 28, 2020

/assign @smarterclayton
per last comment https://bugzilla.redhat.com/show_bug.cgi?id=1828858

@knobunc
Copy link
Contributor

knobunc commented Sep 1, 2020

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, knobunc, marun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a62542d into openshift:master Sep 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 1, 2020

@aojea: All pull requests linked via external trackers have merged:

Bugzilla bug 1828858 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 7, 2020
Merged
Closed
@aojea
Copy link
Author

aojea commented Sep 17, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 17, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 17, 2020

@aojea: new pull request created: #25516

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 19, 2020
Merged
candita added a commit to candita/origin that referenced this pull request May 20, 2021
@candita
Bug 1929396: Revert part of PR openshift#25406 - use ExternalTrafficP…
eed4723 
…olicyLocal
@candita candita mentioned this pull request May 20, 2021
Merged
openshift-merge-robot added a commit that referenced this pull request May 27, 2021
@openshift-merge-robot
Merge pull request #26175 from candita/BZ-1929396-RevertExternalTraff…
58b1008 
…icPolicyLocal

Bug 1929396: Revert part of PR #25406 - use ExternalTrafficPolicyCluster
@yuvalk yuvalk mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@marun marun

@smarterclayton smarterclayton

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@aojea @openshift-ci-robot @marun @knobunc @openshift-bot @openshift-cherrypick-robot @smarterclayton @deads2k @openshift-merge-robot @frobware