Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #25406

/assign aojea

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1828858 with correct target release. Retitling PR to link to clone:
/retitle [release-4.5] Bug 1868490: use LoadBalancers with ExternalTrafficPolicy set to Local

Details

In response to this:

[release-4.5] Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1828858: use LoadBalancers with ExternalTrafficPolicy set to Local [release-4.5] Bug 1868490: use LoadBalancers with ExternalTrafficPolicy set to Local Sep 17, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 17, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1868490, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1828858 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1828858 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

[release-4.5] Bug 1868490: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 17, 2020
@aojea
Copy link

aojea commented Sep 17, 2020

/retest

3 similar comments
@aojea
Copy link

aojea commented Sep 18, 2020

/retest

@aojea
Copy link

aojea commented Sep 28, 2020

/retest

@sgreene570
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd d417bbd link /test e2e-cmd
ci/prow/e2e-aws-serial d417bbd link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

/retest

@aojea
Copy link

aojea commented Oct 21, 2020

/retest
/assign @knobunc

@knobunc
Copy link
Contributor

knobunc commented Oct 22, 2020

/approve

@knobunc
Copy link
Contributor

knobunc commented Oct 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020
@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 22, 2020
@aojea
Copy link

aojea commented Oct 23, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Oct 23, 2020

we had a surprising number of urgent PRs come in for 4.5 today, so i'm making room by untagging this, it should be CPA'd next week.

@bparees bparees removed the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 23, 2020
@aojea
Copy link

aojea commented Oct 27, 2020

it is a duplicate of #25481 , isn't it?
why CI does not show a conflict?

@sgreene570
Copy link
Contributor

it is a duplicate of #25481 , isn't it?
why CI does not show a conflict?

Yea, looks like it.
https://github.com/openshift/origin/blob/release-4.5/test/e2e/upgrade/service/service.go#L53
Strange that this is passing CI...
@aojea we can close this PR, right?

@aojea
Copy link

aojea commented Oct 27, 2020

/close
the commit is in release-4.5 per 28f3eaa

Strange that this is passing CI...

🤷

@openshift-ci-robot
Copy link

@aojea: Closed this PR.

Details

In response to this:

/close
the commit is in release-4.5 per 28f3eaa

Strange that this is passing CI...

🤷

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: An error was encountered removing this pull request from the external tracker bugs for bug 1868490 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 1004: The combination of ext_type_* fields matched more than one External Tracker.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.5] Bug 1868490: use LoadBalancers with ExternalTrafficPolicy set to Local

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants