Skip to content

Conversation

@frobware
Copy link
Contributor

This was disabled in:

#25314

@openshift-ci-robot
Copy link

@frobware: This pull request references Bugzilla bug 1861944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1861944: re-enable service upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 31, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frobware
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@frobware
Copy link
Contributor Author

Testing to see if this was fixed by openshift/kubernetes#300

@frobware frobware changed the title Bug 1861944: re-enable service upgrade Bug 1861944: test/e2e: re-enable service upgrade Jul 31, 2020
@frobware
Copy link
Contributor Author

@marun
Copy link
Contributor

marun commented Aug 4, 2020

/retest

1 similar comment
@smarterclayton
Copy link
Contributor

/retest

@aojea
Copy link

aojea commented Aug 7, 2020

/cc

@aojea
Copy link

aojea commented Aug 7, 2020

/test e2e-aws-upgrade

@openshift-ci-robot
Copy link

@aojea: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test verify
  • /test verify-deps
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run the following jobs:

  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-cmd
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link

aojea commented Aug 7, 2020

@frobware newbie question, how can I check if happens in all cloud providers or just in gcp?
what's the name of the aws job that test the upgrade?

@marun
Copy link
Contributor

marun commented Aug 7, 2020

@frobware newbie question, how can I check if happens in all cloud providers or just in gcp?
what's the name of the aws job that test the upgrade?

As per the bot response missing e2e-aws, running the job would require adding it as a new job to the ci configuration for origin's master branch:

https://github.com/openshift/release/blob/master/ci-operator/config/openshift/origin/openshift-origin-master.yaml

After adding the job to the config, make update would regenerate the job config. Post-generation, it would be necessary to manually set optional: true and run_always: false to ensure that the job was not required to merge and would be run only on-demand.

@aojea
Copy link

aojea commented Aug 11, 2020

/test e2e-aws-upgrade
/test e2e-gcp-upgrade

1 similar comment
@aojea
Copy link

aojea commented Aug 11, 2020

/test e2e-aws-upgrade
/test e2e-gcp-upgrade

@openshift-ci-robot
Copy link

@frobware: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips b8ad647 link /test e2e-aws-fips
ci/prow/e2e-gcp-upgrade b8ad647 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor Author

/hold

Putting on hold as I have been looking at other things since I opened this PR.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2020
@aojea
Copy link

aojea commented Aug 11, 2020

/hold

Putting on hold as I have been looking at other things since I opened this PR.

one run using externaltrafficpolicy to local succeeded, I will check a few times more to see if it was luck 😄
#25406

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2020
@openshift-ci-robot
Copy link

@frobware: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frobware
Copy link
Contributor Author

frobware commented Sep 8, 2020

Closing this as the it doesn't fix the bug and I don't want the POST status in bugzilla to reflect that it's actively been worked on. Will follow up in BZ with assignee.

@frobware frobware closed this Sep 8, 2020
@openshift-ci-robot
Copy link

@frobware: This pull request references Bugzilla bug 1861944. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1861944: test/e2e: re-enable service upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sgreene570
Copy link
Contributor

So, @frobware & @aojea, we have evidence to suggest that #25406 didn't resolve the issue here? I see this test PR was closed before #25406 merged...

@aojea
Copy link

aojea commented Sep 14, 2020

I don' t know if I fully understand your question, , I've added this PRs commit as part of #25406

@sgreene570
Copy link
Contributor

I don' t know if I fully understand your question, , I've added this PRs commit as part of #25406

I think I see whats going on here. @frobware closed this PR in lieu of #25406. That means https://bugzilla.redhat.com/show_bug.cgi?id=1861944 is in fact a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=1828858. I was under the impression this test was still skipped 😆 . Sorry for the confusion, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants