-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 1861944: test/e2e: re-enable service upgrade #25354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1861944: test/e2e: re-enable service upgrade #25354
Conversation
This was disabled in: openshift#25314
|
@frobware: This pull request references Bugzilla bug 1861944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Testing to see if this was fixed by openshift/kubernetes#300 |
Will take a deeper look. |
|
/retest |
1 similar comment
|
/retest |
|
/cc |
|
/test e2e-aws-upgrade |
|
@aojea: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@frobware newbie question, how can I check if happens in all cloud providers or just in gcp? |
As per the bot response missing After adding the job to the config, |
|
/test e2e-aws-upgrade |
1 similar comment
|
/test e2e-aws-upgrade |
|
@frobware: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold Putting on hold as I have been looking at other things since I opened this PR. |
one run using externaltrafficpolicy to local succeeded, I will check a few times more to see if it was luck 😄 |
|
@frobware: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Closing this as the it doesn't fix the bug and I don't want the POST status in bugzilla to reflect that it's actively been worked on. Will follow up in BZ with assignee. |
|
@frobware: This pull request references Bugzilla bug 1861944. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I don' t know if I fully understand your question, , I've added this PRs commit as part of #25406 |
I think I see whats going on here. @frobware closed this PR in lieu of #25406. That means https://bugzilla.redhat.com/show_bug.cgi?id=1861944 is in fact a dupe of https://bugzilla.redhat.com/show_bug.cgi?id=1828858. I was under the impression this test was still skipped 😆 . Sorry for the confusion, thanks!! |
This was disabled in:
#25314