-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add optional e2e-aws-upgrade job #10785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"Application behind service load balancer with PDB is not disrupted" The upgrade test suite has a test that uses the cloud provider load balancer, but only has a job for master that runs in gcp. In order to discard problems with cloud provider load balancers, we can run the test in aws to compare the results. The job is optional and only can be run on demand. Signed-off-by: Antonio Ojea <aojea@redhat.com>
|
/assign @marun |
|
/assign @alvaroaleman |
|
I can not review jobs, the repository owners need to do that |
ups, sorry, seems I confused things |
|
good description /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aojea: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… AWS update jobs Like the cluster-version operator has been doing since db0d358 (CVO: add rollback tests for 4.6+, 2020-10-14, openshift#12789), and which we used to do much more broadly until 6663962 (upgrade workflows: remove abort-at from default TEST_OPTIONS, 2020-10-08, openshift#12544). I'm personally in favor of the broad approach, because we want minor rollbacks to work, so if we break master->PR rollback, we're in big trouble. But even with the narrow scoping for rollback jobs, origin's test are implementing and monitoring the rollback functionality, so they deserve to have a local test excercising it. I've added this to the AWS update job, because Clayton wants it to be optional, and the AWS update job has been optional and not always-run since it was born in bd85872 (add optional e2e-aws-upgrade job, 2020-08-10, openshift#10785).
"Application behind service load balancer with PDB is not disrupted"
The upgrade test suite has a test that uses the cloud
provider load balancer, but only has a job for master that runs
in gcp.
In order to discard problems with cloud provider load balancers, we
can run the test in aws to compare the results.
The job is optional and only can be run on demand.
Signed-off-by: Antonio Ojea aojea@redhat.com
xref: openshift/origin#25354 (comment)