Skip to content

Conversation

@aojea
Copy link
Contributor

@aojea aojea commented Aug 10, 2020

"Application behind service load balancer with PDB is not disrupted"

The upgrade test suite has a test that uses the cloud
provider load balancer, but only has a job for master that runs
in gcp.

In order to discard problems with cloud provider load balancers, we
can run the test in aws to compare the results.
The job is optional and only can be run on demand.

Signed-off-by: Antonio Ojea aojea@redhat.com

xref: openshift/origin#25354 (comment)

"Application behind service load balancer with PDB is not disrupted"

The upgrade test suite has a test that uses the cloud
provider load balancer, but only has a job for master that runs
in gcp.

In order to discard problems with cloud provider load balancers, we
can run the test in aws to compare the results.
The job is optional and only can be run on demand.

Signed-off-by: Antonio Ojea <aojea@redhat.com>
@aojea
Copy link
Contributor Author

aojea commented Aug 10, 2020

/assign @marun

@aojea
Copy link
Contributor Author

aojea commented Aug 10, 2020

/assign @alvaroaleman

@alvaroaleman
Copy link
Contributor

I can not review jobs, the repository owners need to do that
/unassign

@aojea
Copy link
Contributor Author

aojea commented Aug 10, 2020

I can not review jobs, the repository owners need to do that
/unassign

ups, sorry, seems I confused things

@deads2k
Copy link
Contributor

deads2k commented Aug 10, 2020

good description

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit bde0ab9 into openshift:master Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

@aojea: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
Details

In response to this:

"Application behind service load balancer with PDB is not disrupted"

The upgrade test suite has a test that uses the cloud
provider load balancer, but only has a job for master that runs
in gcp.

In order to discard problems with cloud provider load balancers, we
can run the test in aws to compare the results.
The job is optional and only can be run on demand.

Signed-off-by: Antonio Ojea aojea@redhat.com

xref: openshift/origin#25354 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/openshift-release that referenced this pull request Mar 17, 2021
… AWS update jobs

Like the cluster-version operator has been doing since db0d358
(CVO: add rollback tests for 4.6+, 2020-10-14, openshift#12789), and which we
used to do much more broadly until 6663962 (upgrade workflows:
remove abort-at from default TEST_OPTIONS, 2020-10-08, openshift#12544).  I'm
personally in favor of the broad approach, because we want minor
rollbacks to work, so if we break master->PR rollback, we're in big
trouble.  But even with the narrow scoping for rollback jobs, origin's
test are implementing and monitoring the rollback functionality, so
they deserve to have a local test excercising it.

I've added this to the AWS update job, because Clayton wants it to be
optional, and the AWS update job has been optional and not always-run
since it was born in bd85872 (add optional e2e-aws-upgrade job,
2020-08-10, openshift#10785).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants