CVO: add rollback tests for 4.6+ #12789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
vrutkovs
force-pushed
the
cvo-rollbacktests
branch
from
55ab1d8 to
437fefa
Compare
Contributor
Author
|
GCP quota issues |
Contributor
Author
|
/retest 4.7 passed, but crashed on |
Contributor
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vrutkovs
force-pushed
the
cvo-rollbacktests
branch
2 times, most recently
from
8d1e0b6 to
42cd8c7
Compare
wking
reviewed
Oct 20, 2020
...tor/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
Outdated
Show resolved
Hide resolved
vrutkovs
force-pushed
the
cvo-rollbacktests
branch
5 times, most recently
from
72d75ff to
bfa2d6f
Compare
wking
reviewed
Oct 22, 2020
Member
There was a problem hiding this comment.
I don't think we need to set this explicitly, since it's the default:
$ git --no-pager grep TEST_COMMAND ci-operator/step-registry/openshift/upgrade/gcp/loki/
ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml: TEST_COMMAND: "run-upgrade"
Contributor
Author
There was a problem hiding this comment.
env section completely overwrites existing one, so all parameters have to duplicated here.
I filed https://issues.redhat.com/browse/DPTP-1644 to investigate templating in step workflows
wking
reviewed
Oct 22, 2020
...tor/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
Outdated
Show resolved
Hide resolved
wking
reviewed
Oct 22, 2020
...tor/config/openshift/cluster-version-operator/openshift-cluster-version-operator-master.yaml
Outdated
Show resolved
Hide resolved
vrutkovs
force-pushed
the
cvo-rollbacktests
branch
from
bfa2d6f to
a3515af
Compare
This adds `e2e-rollback` tests to 4.6+ branches to verify that updated version can be rolled back to the original
vrutkovs
force-pushed
the
cvo-rollbacktests
branch
from
a3515af to
db0d358
Compare
Contributor
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@vrutkovs: Updated the following 6 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Mar 17, 2021
… AWS update jobs Like the cluster-version operator has been doing since db0d358 (CVO: add rollback tests for 4.6+, 2020-10-14, openshift#12789), and which we used to do much more broadly until 6663962 (upgrade workflows: remove abort-at from default TEST_OPTIONS, 2020-10-08, openshift#12544). I'm personally in favor of the broad approach, because we want minor rollbacks to work, so if we break master->PR rollback, we're in big trouble. But even with the narrow scoping for rollback jobs, origin's test are implementing and monitoring the rollback functionality, so they deserve to have a local test excercising it. I've added this to the AWS update job, because Clayton wants it to be optional, and the AWS update job has been optional and not always-run since it was born in bd85872 (add optional e2e-aws-upgrade job, 2020-08-10, openshift#10785).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
e2e-agnostic-upgradetests to do rollback tests in 4.5+ branches to verify that updated version can be rolled back to the original