Skip to content

Bug 1886131: upgrade workflows: remove abort-at from default TEST_OPTIONS #12544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 9, 2020
Merged

Bug 1886131: upgrade workflows: remove abort-at from default TEST_OPTIONS #12544

openshift-merge-robot merged 1 commit into from
Oct 9, 2020

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Oct 8, 2020

Setting abort-at starts a rollback, which is not applicable to all upgrade jobs

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@vrutkovs vrutkovs mentioned this pull request Oct 8, 2020
Merged
@hexfusion
Copy link
Contributor

hexfusion commented Oct 8, 2020

LGTM

@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 8, 2020

/cc @wking @stevekuznetsov

@vrutkovs vrutkovs changed the title upgrade workflows: remove abort-at from default TEST_OPTIONS Bug 1886131: upgrade workflows: remove abort-at from default TEST_OPTIONS Oct 8, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2020

@vrutkovs: This pull request references Bugzilla bug 1886131, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1886131: upgrade workflows: remove abort-at from default TEST_OPTIONS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Oct 8, 2020

Can we add it to at least the CVO presubmits? And ideally all update CI that covers patch updates..

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 8, 2020

/hold

Contains debug commits

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
upgrade workflows: remove abort-at from default TEST_OPTIONS
6663962 
Setting abort-at starts a rollback, which is not applicable to all upgrade jobs
@vrutkovs vrutkovs force-pushed the upgrade-workflows-remove-abort branch from a0d70b6 to 8582525 Compare October 8, 2020 18:11
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 9, 2020

CVO presumbit - pass
4.4 -> 4.5 ci - pass

@vrutkovs vrutkovs force-pushed the upgrade-workflows-remove-abort branch from 8582525 to 6663962 Compare October 9, 2020 07:43
@vrutkovs
Copy link
Contributor Author

vrutkovs commented Oct 9, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs mentioned this pull request Oct 9, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit e6988a0 into openshift:master Oct 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

@vrutkovs: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1886131 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1886131: upgrade workflows: remove abort-at from default TEST_OPTIONS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2020

@vrutkovs: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-upgrade-aws-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/aws/loki/openshift-upgrade-aws-loki-workflow.yaml
    • key openshift-upgrade-gcp-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-upgrade-aws-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/aws/loki/openshift-upgrade-aws-loki-workflow.yaml
    • key openshift-upgrade-gcp-loki-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/gcp/loki/openshift-upgrade-gcp-loki-workflow.yaml
Details

In response to this:

Setting abort-at starts a rollback, which is not applicable to all upgrade jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 14, 2020
Closed
Merged
@wking wking mentioned this pull request Mar 17, 2021
Merged
wking added a commit to wking/openshift-release that referenced this pull request Mar 17, 2021
@wking
ci-operator/config/openshift/origin/openshift-origin-master: Rollback…
e8bc08d 
… AWS update jobs

Like the cluster-version operator has been doing since db0d358
(CVO: add rollback tests for 4.6+, 2020-10-14, openshift#12789), and which we
used to do much more broadly until 6663962 (upgrade workflows:
remove abort-at from default TEST_OPTIONS, 2020-10-08, openshift#12544).  I'm
personally in favor of the broad approach, because we want minor
rollbacks to work, so if we break master->PR rollback, we're in big
trouble.  But even with the narrow scoping for rollback jobs, origin's
test are implementing and monitoring the rollback functionality, so
they deserve to have a local test excercising it.

I've added this to the AWS update job, because Clayton wants it to be
optional, and the AWS update job has been optional and not always-run
since it was born in bd85872 (add optional e2e-aws-upgrade job,
2020-08-10, openshift#10785).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@deads2k deads2k Awaiting requested review from deads2k

@wking wking Awaiting requested review from wking

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vrutkovs @hexfusion @openshift-ci-robot @wking @stevekuznetsov @openshift-merge-robot